commit efa9388e358952938301d56b0b7b62d5a2464442
author haoyuewang <haoyuewang@google.com> Wed Oct 27 16:27:29 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Oct 27 16:28:40 2021 -0700
tree 23bac92a178c6a41e51219c7aa22b0b64a74903c
parent 9234b5442c61dc87ab97300e885f1ceb55f00016

Remove obsolete QUIC_BUG(quic_bug_5196).

This QUIC_BUG was added to provide more detailed debugging information. Now that we have root cause the issue, the QUIC_BUG can be removed so that the test with fixing flag being false would proceed to success (verified by set --test_arg='--gfe2_flip_all_feature_flags_to_true_for_test=true' and set quic_flush_pending_frames_and_padding_bytes_on_migration false ).

PiperOrigin-RevId: 406007363

quic/core/quic_connection.cc

diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index aa598e4..939208b 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -5347,17 +5347,6 @@
           std::move(alternative_path_.rtt_stats).value());
     }
   }
-  if (packet_creator_.HasPendingFrames() ||
-      packet_creator_.pending_padding_bytes() > 0) {
-    QUIC_BUG(quic_bug_5196)
-        << "Starts effective peer migration with pending frame types: "
-        << packet_creator_.GetPendingFramesInfo() << ". pending_padding_bytes: "
-        << packet_creator_.pending_padding_bytes()
-        << ". Address change type is " << AddressChangeTypeToString(type)
-        << ". Current frame type: " << framer_.current_received_frame_type()
-        << ". Previous frame type: "
-        << framer_.previously_received_frame_type();
-  }
   // Update to the new peer address.
   UpdatePeerAddress(last_received_packet_info_.source_address);
   // Update the default path.