)]}'
{
  "commit": "ed1fe4f83c350bfccf42e612c1111956847721fb",
  "tree": "ab7e2674766cbebeaa932d21c1da797d90e46f13",
  "parents": [
    "89fc30e93851e9f51a94c0993bcbc3e300d30034"
  ],
  "author": {
    "name": "bnc",
    "email": "bnc@google.com",
    "time": "Wed Jul 01 04:48:53 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Jul 01 04:49:37 2020 -0700"
  },
  "message": "Do not drop too many packages in PacketDroppingTestWriter.\n\nAfter each dropped package, succeed in writing at least two packages before\ndropping another one (unless fake drop percentage is 100).  This is to avoid\ntest flakiness due to too many dropped packages.  For example, if both the\nserver and the client happen to drop every other package, no probe ack will ever\nbe received.  See https://crbug.com/1095063 for more context.\n\nWithout this change, I can reproduce the following errors in AckNotifierWithPacketLossAndBlockedSocket tests:\n- in the internal code base, test flakiness (QUIC_TOO_MANY_RTOS errors),\n- in Chromium debug build, test flakiness (QUIC_TOO_MANY_RTOS errors),\n- in Chromium MSAN build, both test flakiness and test timeouts.\n\nWith this change, I ran all of AckNotifierWithPacketLossAndBlockedSocket in Chromium in both setups, and all of EndToEndTests with internal tools, each of them 1000 times, and they all passed.\nTest-only change\n\nPiperOrigin-RevId: 319202623\nChange-Id: I8aedcf3e790a947d3d6fa341f6064a7465156472\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c897fdc33e77c4cd958190b72edeedb3c613a460",
      "old_mode": 33188,
      "old_path": "quic/test_tools/packet_dropping_test_writer.cc",
      "new_id": "d840e4db3b46768c7dd9b12ef03cdc2856b89a35",
      "new_mode": 33188,
      "new_path": "quic/test_tools/packet_dropping_test_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "f066e9191e407df563a9fad79445c10068946c6b",
      "old_mode": 33188,
      "old_path": "quic/test_tools/packet_dropping_test_writer.h",
      "new_id": "47a3216eebe782b7c5db60b66b8d740e78670824",
      "new_mode": 33188,
      "new_path": "quic/test_tools/packet_dropping_test_writer.h"
    }
  ]
}