tree 56eab85a7bef69210ca1e3036b7bbdc99371bc02
parent 577b5487b8be73b164712ce69eb383f79f8c3baa
author dschinazi <dschinazi@google.com> 1578958961 -0800
committer Copybara-Service <copybara-worker@google.com> 1578959000 -0800

Refactor handling of supported versions

This CL introduces ParsedQuicVersionIsValid and refactors AllSupportedVersions to use it. It slightly changes how ParseQuicVersionLabel ParseQuicVersionString work, but only in the parsing of invalid versions such as T043. This does not change the behavior of the GFE in practice because packets of these versions would either way be time-waited because T043 cannot be in the CurrentSupportedVersions list.

This CL also has a minor fix to QuicFramer to ensure that, when processing short headers, the decision to fill packet_number_length is based on the framer's version as opposed to the empty version in the short header. HasHeaderProtection returns false for the empty version meaning that packet_number_length would always be filled in where the code is changed by this CL. However, in versions that do support header protection, packet_number_length is filled in by RemoveHeaderProtection <http://shortn/_Pfz02eXtt7>, which is gated on the version from the framer <http://shortn/_HHqgFPW8lP>. Therefore this change does not change behavior.

gfe-relnote: refactor, no behavior change, not flag-protected
PiperOrigin-RevId: 289535913
Change-Id: I864a9f65c6dc23ea1665f49893476a44e3db1493