tree 075b279c5b479077685762329a6e0a23047975fc
parent c8b1052048f1755982feef370c7a07d4418d0f04
author martinduke <martinduke@google.com> 1791825040 -0700
committer Copybara-Service <copybara-worker@google.com> 1791825099 -0700

Synthesize an EndOfGroup object when FIN arrives without data.

Currently, when parsing a has_end_of_group stream, when the object is complete but no FIN has arrived, it can't be delivered because we don't know the status yet. If a FIN arrives later, the object's status will change to kEndOfGroup.

This introduces object delivery latency. Furthermore, there is a bug in that it can induce calls to OnObjectFragment() where the offset is > 0 and the payload is empty, which is not envisioned in the API and is causing QUICHE_BUG in interop.

This CL removes the kAwaitingNextByte state; any object with payload can be delivered. If a FIN arrives immediately after, the parser will create a synthetic kEndOfGroup object.

If the payload is delivered in parts, it is possible for the object_status to suddenly change from Normal to EndOfGroup. PublishedObjectMetadata no longer regards this as a malformed track. This might open up some shenanigans where two publishers have different EndsOfGroup, but detection of that is best-effort. There is a performance advantage because if the last Normal object is delivered with EndOfGroup status, it is able to be FINed / EOGed immediately rather than waiting for a separate, synthetic object to arrive.

PiperOrigin-RevId: 997993975