)]}' { "commit": "d34eb6e55662b9a0f0a17be588aa79b04b31a22a", "tree": "8c128731e3c8b2d0d47484201061b5cadcf35207", "parents": [ "e87010ff958c9397ee861e00d7747de6f3938e19" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Wed Dec 08 13:50:23 2021 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 08 13:52:10 2021 -0800" }, "message": "Add `max_header_bytes` to OgHttp2Session::Options() and send in initial SETTINGS.\n\nThis configurable option allows OgHttp2Session\u0027s HPACK decoder to adjust its\ndecoding buffer size and max allowed header block size in a similar strategy to\nHttp2Dispatcher [1]. This change is important to allow OgHttp2Session to decode\nheaders following Envoy\u0027s `max_headers_kb_` [2].\n\nWhen locally added to Envoy\u0027s Http2Options [3], this change allows the\nfollowing codec_impl_tests to pass: LargeRequestHeadersAtLimitAccepted,\nLargeRequestHeadersInvokeResetStream, LargeMethodRequestEncode,\nLargeRequestHeadersOverDefaultCodecLibraryLimit (arguably no longer needed),\nLargeRequestHeadersAtMaxConfigurable, LargeRequestHeadersAccepted.\n\n[1] e.g., http://google3/gfe/gfe2/http2/http2_backend_dispatcher.cc;l\u003d221-226;rcl\u003d414330428\n[2] http://google3/third_party/envoy/src/source/common/http/http2/codec_impl.h;l\u003d549;rcl\u003d414330428\n[3] http://google3/third_party/envoy/src/source/common/http/http2/codec_impl.h;l\u003d196;rcl\u003d414009764\n\nPiperOrigin-RevId: 415087562\n", "tree_diff": [ { "type": "modify", "old_id": "cc0cdac439b11878d5cbc823a90357ac57d5e9e9", "old_mode": 33188, "old_path": "http2/adapter/oghttp2_adapter_test.cc", "new_id": "6235d34ac990c9ecd396bcdfce84287226160e0c", "new_mode": 33188, "new_path": "http2/adapter/oghttp2_adapter_test.cc" }, { "type": "modify", "old_id": "19f5dada4da44f3fadc384e5f3424ecee3b7c120", "old_mode": 33188, "old_path": "http2/adapter/oghttp2_session.cc", "new_id": "82d9d872e0703a12bb68fb957330d4fb796557af", "new_mode": 33188, "new_path": "http2/adapter/oghttp2_session.cc" }, { "type": "modify", "old_id": "670b2367f45ab3b4d8d631b503be92e6dd6ec235", "old_mode": 33188, "old_path": "http2/adapter/oghttp2_session.h", "new_id": "fd7bdc2bf409f505083e2688a3ca47b9b26dae97", "new_mode": 33188, "new_path": "http2/adapter/oghttp2_session.h" } ] }