)]}' { "commit": "d016c016b69388a6e6940a5da165acfeca30494d", "tree": "01f74638bbfbd72c808aa0c9f79dfd833dd7334b", "parents": [ "d5c547c281b0f90eaebc8d16028a21bf16612c52" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Mon Feb 07 15:44:02 2022 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 07 15:45:57 2022 -0800" }, "message": "Rollback for 4 changelists related to QUICv2.\n\n*** Reason for rollback ***\n\nRollback QUICv2 until we figure out the impact on Chrome.\n\n*** Original change descriptions ***\n\nFix C++ defensive coding advice from the QUICv2 CL (cl/424961568).\n\nThere is much more to be done, but that could get out of control fast. Let me know if you want to abandon this, push more into this CL, or commit as-is.\n\n***\n\nFix Intermittent Contagion Test failure.\n\nSince version mismatch is known to fail ungracefully, the fix is to make sure v2 support matches between the two GFEs\n\n***\n\nRemove enabling_blocked_by for the QUICv2 bug, leaving only the version-negotiation bug.\n\n***\n\nImplement QUICv2 in QUICHE.\n\nThis CL reflects draft-ietf-quic-v2-01, except for the version negotiation bits -- therefore, the enable flag is blocked by the VN bug.\n\nThere are a bunch of changes to line breaks, particularly in quic_framer, that I believe came from the recently updated code checkers. I\u0027m ignoring some new code checks that suggest changes to existing code constructs -- perhaps we should address the defensive coding stuff in another CL.\n\n***\n\nPiperOrigin-RevId: 427037417\n", "tree_diff": [ { "type": "modify", "old_id": "05bbdfe63212dd585550df6705dc514612c4c35d", "old_mode": 33188, "old_path": "quic/core/crypto/crypto_utils.cc", "new_id": "1812e73e5aeb1141561398a2fc8170fbcb29cdfc", "new_mode": 33188, "new_path": "quic/core/crypto/crypto_utils.cc" }, { "type": "modify", "old_id": "fce62018823e8df3c49e3a5cfe13ad3a294981c4", "old_mode": 33188, "old_path": "quic/core/crypto/crypto_utils.h", "new_id": "5e603f82bafad093f8e50a55f1572e1c3a39f2ec", "new_mode": 33188, "new_path": "quic/core/crypto/crypto_utils.h" }, { "type": "modify", "old_id": "f0d944b4fea90cd5b3b30386bc9b0f0735076edf", "old_mode": 33188, "old_path": "quic/core/crypto/crypto_utils_test.cc", "new_id": "f0706b4c883183fdc23687eb2e6cc948cda89400", "new_mode": 33188, "new_path": "quic/core/crypto/crypto_utils_test.cc" }, { "type": "modify", "old_id": "7fbc5ae33db878d5373cd19dcfe87926988a2986", "old_mode": 33188, "old_path": "quic/core/handshaker_delegate_interface.h", "new_id": "fb0ad6627c206748f7cdb8e07c78fab91153568d", "new_mode": 33188, "new_path": "quic/core/handshaker_delegate_interface.h" }, { "type": "modify", "old_id": "cad9cacb0224eec83119dfb1010bab1708dde98d", "old_mode": 33188, "old_path": "quic/core/http/end_to_end_test.cc", "new_id": "04740e8a1bdefe901b94d67db0f59954e347f1ef", "new_mode": 33188, "new_path": "quic/core/http/end_to_end_test.cc" }, { "type": "modify", "old_id": "053849fb39c2f0a56037fff06a227e2e64e7000b", "old_mode": 33188, "old_path": "quic/core/quic_connection_test.cc", "new_id": "d9d1a34e25dca92fbe49ae26629259f2495bd856", "new_mode": 33188, "new_path": "quic/core/quic_connection_test.cc" }, { "type": "modify", "old_id": "add5164d674a0bc06e98fa4336a22d1089d33141", "old_mode": 33188, "old_path": "quic/core/quic_dispatcher_test.cc", "new_id": "ca4ae483af8cbfdcc44492a67bca7e5bcd7373ad", "new_mode": 33188, "new_path": "quic/core/quic_dispatcher_test.cc" }, { "type": "modify", "old_id": "b692cf57618e28674ff7aee8570c80158656d1f1", "old_mode": 33188, "old_path": "quic/core/quic_flags_list.h", "new_id": "77a53e2fed315c46664786271348a5b0a2305369", "new_mode": 33188, "new_path": "quic/core/quic_flags_list.h" }, { "type": "modify", "old_id": "da28e4c5b5c50ba57fd629969ef998474abc3356", "old_mode": 33188, "old_path": "quic/core/quic_framer.cc", "new_id": "d292d84d058cd4b0000f83754a64d8c2500609d6", "new_mode": 33188, "new_path": "quic/core/quic_framer.cc" }, { "type": "modify", "old_id": "d24664dbded62ae30923ac68cb0f226e9ba17756", "old_mode": 33188, "old_path": "quic/core/quic_framer_test.cc", "new_id": "d893eb9bfcd92c230f517745fc738fc701533e73", "new_mode": 33188, "new_path": "quic/core/quic_framer_test.cc" }, { "type": "modify", "old_id": "88ae992880d87904b71733b4c7e8cc241359563c", "old_mode": 33188, "old_path": "quic/core/quic_session.h", "new_id": "d06e1fe43a462cbd914adfc19a21b2d28ffd1df6", "new_mode": 33188, "new_path": "quic/core/quic_session.h" }, { "type": "modify", "old_id": "4a8479749f229366f55d38a64ee4e1ad53fb64cb", "old_mode": 33188, "old_path": "quic/core/quic_version_manager.cc", "new_id": "13e590d5cdd972a417c55cefac22418ff50484f4", "new_mode": 33188, "new_path": "quic/core/quic_version_manager.cc" }, { "type": "modify", "old_id": "44e134ac363c601bb89f643b88f8f90042c5db50", "old_mode": 33188, "old_path": "quic/core/quic_version_manager.h", "new_id": "af44d341a93dae18f10b0d69b15297af607acbd4", "new_mode": 33188, "new_path": "quic/core/quic_version_manager.h" }, { "type": "modify", "old_id": "aa4581eb9a6d03cac2dc5df85f7195836d49ef27", "old_mode": 33188, "old_path": "quic/core/quic_version_manager_test.cc", "new_id": "403009abc3cda73b4d85811896609b84ae92dfc5", "new_mode": 33188, "new_path": "quic/core/quic_version_manager_test.cc" }, { "type": "modify", "old_id": "b9a48b9f20579066fa16097cd65d885c79f0eaa4", "old_mode": 33188, "old_path": "quic/core/quic_versions.cc", "new_id": "19fb6ad2962d6e619c6d981c764649117295f1d7", "new_mode": 33188, "new_path": "quic/core/quic_versions.cc" }, { "type": "modify", "old_id": "99d3b2f9893c481184487a6ce3c438c20d625fd8", "old_mode": 33188, "old_path": "quic/core/quic_versions.h", "new_id": "c6e24068b989d6ee0fe5e46fd7b5afb6d098717c", "new_mode": 33188, "new_path": "quic/core/quic_versions.h" }, { "type": "modify", "old_id": "7df721a90e28b8a82fb165688cab889f2b537129", "old_mode": 33188, "old_path": "quic/core/quic_versions_test.cc", "new_id": "98b8574f58cc2b77051964491b98f7c0daa572bd", "new_mode": 33188, "new_path": "quic/core/quic_versions_test.cc" }, { "type": "modify", "old_id": "2eee1cc75599791f07d6c59840ff7cc36a959c9c", "old_mode": 33188, "old_path": "quic/core/tls_handshaker.cc", "new_id": "175260bd3f83bf7946f2518b2ad5175fc3cca2b8", "new_mode": 33188, "new_path": "quic/core/tls_handshaker.cc" } ] }