)]}'
{
  "commit": "cf0f085217c842fb5c04dde1025a3ef8f19fdbbc",
  "tree": "349211ccb1e5d255dcc3121513aea611547ae0cc",
  "parents": [
    "d51c21705bba1aee58936cb19387eebfe8b71cf8"
  ],
  "author": {
    "name": "dschinazi",
    "email": "dschinazi@google.com",
    "time": "Thu Jul 22 17:06:46 2021 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Thu Jul 22 17:07:31 2021 -0700"
  },
  "message": "Fix QUIC insecure randomness on Windows 7\n\nThese tests were disabled recently due to a rare crash on Windows 7. We tracked the crash down to the fact that taking the address of a static thread_local uint64_t[4] is apparently buggy on Windows 7. This change instead initializes that variable by assignment to sidestep the issue.\n\nWe\u0027ve confirmed that this change fixes the Windows 7 Chrome crasher:\nhttps://chromium-swarm.appspot.com/task?id\u003d54e82650dc386a10\n\nNote that this CL is not flag-protected because that would require two separate implementations of Xoshiro which would double the amount of thread_local storage required. That could cause issues on some platforms.\n\nPiperOrigin-RevId: 386354470\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "56657b507f96272f4c4199e4c670960bc35dc8e3",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_random.cc",
      "new_id": "d3190c626e7e31abb33c37f3d30f561ef4d2c345",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_random.cc"
    },
    {
      "type": "modify",
      "old_id": "67963ce0eb4c837173f28b3c7d99f28e65bb98b4",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_random_test.cc",
      "new_id": "ab279185fa75eedf86e3f678c79501f82af68833",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_random_test.cc"
    },
    {
      "type": "modify",
      "old_id": "9aa3c2cd9af5922e00d4497d46bbf22e2d361a6f",
      "old_mode": 33188,
      "old_path": "quic/core/quic_connection_test.cc",
      "new_id": "301639b0220bc8d93f53b2cc285b7c488aa4dda3",
      "new_mode": 33188,
      "new_path": "quic/core/quic_connection_test.cc"
    },
    {
      "type": "modify",
      "old_id": "6237bc6a93b146672a41184c1b6857a1282a257d",
      "old_mode": 33188,
      "old_path": "quic/core/quic_framer_test.cc",
      "new_id": "f36bf5c78c7ebc5f7280aa516edd40647f074f24",
      "new_mode": 33188,
      "new_path": "quic/core/quic_framer_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c31d28923645c0ad5f7832d49bb64b3e366524fe",
      "old_mode": 33188,
      "old_path": "quic/core/quic_time_wait_list_manager_test.cc",
      "new_id": "f47bdf2fed85e0ede8f8145a19efd54dfc81177a",
      "new_mode": 33188,
      "new_path": "quic/core/quic_time_wait_list_manager_test.cc"
    }
  ]
}
