)]}' { "commit": "c0e11a33f427a7a17d63b22ad12ba740f2cc75ed", "tree": "72486cc3758fd37a819a368dcf1b40b31e8d3bea", "parents": [ "e3768aabf74aab1daa845da724c371ed4ba33643" ], "author": { "name": "dschinazi", "email": "dschinazi@google.com", "time": "Tue Oct 12 12:36:31 2021 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 12 12:37:26 2021 -0700" }, "message": "Ignore key_update_not_yet_support transport parameter\n\nWhen we first introduced IETF QUIC key update, we were communicating with older versions of our implementation that didn\u0027t support this feature. If we updated keys when communicating with that older software, the connection would fail. To avoid that, we had added a temporary key_update_not_yet_support transport parameter that would disable key updates. We stopped sending that transport parameter when we added support for key updates in Chrome m88. That version is no longer in any experiments, and also that version did not yet have IETF QUIC default-enabled, so we are guaranteed to not be communicating using IETF QUIC with this old software any more. It\u0027s therefore safe to remove this transport parameter as it no longer provides value. Once we deprecate the flag, we\u0027ll remove transport parameter entirely.\n\nProtected by FLAGS_quic_reloadable_flag_quic_ignore_key_update_not_yet_supported.\n\nPiperOrigin-RevId: 402628993\n", "tree_diff": [ { "type": "modify", "old_id": "dcd2fc906236a3668fada6469c2b36faaf0d5111", "old_mode": 33188, "old_path": "quic/core/crypto/transport_parameters.cc", "new_id": "fec6cc5cfad4b0e2548a6ca07bfc48e3f625d522", "new_mode": 33188, "new_path": "quic/core/crypto/transport_parameters.cc" }, { "type": "modify", "old_id": "a758d8153666d6081302865876246595e2426c65", "old_mode": 33188, "old_path": "quic/core/crypto/transport_parameters_test.cc", "new_id": "05ada686bf7e0f0bd9db0cf3707658b44b79026a", "new_mode": 33188, "new_path": "quic/core/crypto/transport_parameters_test.cc" }, { "type": "modify", "old_id": "b40bd6cfe0987549f67cb8425e9ba891d7dfa38b", "old_mode": 33188, "old_path": "quic/core/quic_flags_list.h", "new_id": "3416be777f30cf9879db5c134077c52dbd571048", "new_mode": 33188, "new_path": "quic/core/quic_flags_list.h" }, { "type": "modify", "old_id": "4e47a6395ce45c0703f8b3ca4a818b66a5c1bcbd", "old_mode": 33188, "old_path": "quic/core/tls_server_handshaker.cc", "new_id": "fba927f1b7f51af6ee4015913e4a0e396d7094b3", "new_mode": 33188, "new_path": "quic/core/tls_server_handshaker.cc" } ] }