)]}' { "commit": "bba9a18e81914bf4bd106e03c167058afb1c6609", "tree": "0e5f9d181571277f9f5808781bebfaaa7bdd6f3a", "parents": [ "2a6291128e31550c73622cf3ac2e00da51c64069" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Fri Jul 23 17:40:17 2021 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 23 17:40:52 2021 -0700" }, "message": "Initialize SimpleRandom::buffer_offset_ in quic_test_utils\n\nA few QUIC tests seemed like they might have been failing on Chromium\u0027s Win 7 bots because quic_test_utils\u0027s SimpleRandom::RandUint64 was being accessed out of bounds. [0] After the discussion in crbug.com/1228245#c23, this seems like a red herring: the initial stack trace was corrupted (the waterfall bots in question were running with a low symbol_level). The issue seems like it was actually in quic::DefaultRandom, not quic::test::SimpleRandom.\n\nBut, in any event, it seems like a safety improvement to initialize the buffer offset in SimpleRandom: this CL goes ahead and does so, even if it might not be necessary for addressing the crashes in question.\n\n[0] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8840889728099773792/+/u/net_unittests/Deterministic_failure:_QuicTimeWaitListManagerTest.SendStatelessResetInResponseToShortHeaders__status_CRASH_\n\nPiperOrigin-RevId: 386564749\n", "tree_diff": [ { "type": "modify", "old_id": "e10d9c17af888ded77ddd128233ba8c81ccd18b0", "old_mode": 33188, "old_path": "quic/test_tools/quic_test_utils.h", "new_id": "17aa9209bfab417540889dd6c364f125363f9ce7", "new_mode": 33188, "new_path": "quic/test_tools/quic_test_utils.h" } ] }