Automated g4 rollback of changelist 803740716.
*** Reason for rollback ***
Broke external QUICHE builds which use an earlier version of absl.
*** Original change description ***
Fix 3 ClangInliner findings:
* The use of this symbol has been deprecated and marked for inlining. The function being deprecated is absl::WriterMutexLock::WriterMutexLock. (3 times)
See go/inliner-lsc for more information on why you've received this change and why it is important.
This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/inliner-bug for category ClangInliner...
***
PiperOrigin-RevId: 805134177
diff --git a/quiche/quic/qbone/bonnet/icmp_reachable.cc b/quiche/quic/qbone/bonnet/icmp_reachable.cc
index 76fd84e..5b6c212 100644
--- a/quiche/quic/qbone/bonnet/icmp_reachable.cc
+++ b/quiche/quic/qbone/bonnet/icmp_reachable.cc
@@ -103,7 +103,7 @@
}
alarm_->Set(clock_->Now());
- absl::WriterMutexLock mu(header_lock_);
+ absl::WriterMutexLock mu(&header_lock_);
icmp_header_.icmp6_type = ICMP6_ECHO_REQUEST;
icmp_header_.icmp6_code = 0;
@@ -134,7 +134,7 @@
absl::string_view(buffer, size));
auto* header = reinterpret_cast<const icmp6_hdr*>(&buffer);
- absl::WriterMutexLock mu(header_lock_);
+ absl::WriterMutexLock mu(&header_lock_);
if (header->icmp6_data32[0] != icmp_header_.icmp6_data32[0]) {
QUIC_VLOG(2) << "Unexpected response. id: " << header->icmp6_id
<< " seq: " << header->icmp6_seq
@@ -159,7 +159,7 @@
}
void IcmpReachable::OnAlarm() {
- absl::WriterMutexLock mu(header_lock_);
+ absl::WriterMutexLock mu(&header_lock_);
if (end_ < start_) {
QUIC_VLOG(1) << "Timed out on sequence: " << icmp_header_.icmp6_seq;
