)]}'
{
  "commit": "a676db9907fc9273bfce683a5bcf2f39ff29cbec",
  "tree": "fb6e46f71f14d04b7c42f3e0b107724fc1f81471",
  "parents": [
    "67c93924d8c4242b2bcc7e753431beed47716044"
  ],
  "author": {
    "name": "Vitaly Goldshteyn",
    "email": "goldvitaly@google.com",
    "time": "Tue Jan 14 08:11:16 2025 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Jan 14 08:12:13 2025 -0800"
  },
  "message": "LSC: Apply performance-unnecessary-value-param where it matters for performance.\n\nThis cl was generated with go/gwp-clang-tidy.\nThe following lines are helpful in [determining](http://go/gwp-clang-tidy#metrics-summary) the impact of the change:\n```\ngwp_clang_tidy_metric: 667.275 gcus\ngwp_clang_tidy_metric_for_key: 667.275 gcus\ngwp_clang_tidy_fn_name: quic::(anonymous namespace)::AppendIetfConnectionIds(bool, bool, quic::QuicConnectionId, quic::QuicConnectionId, quic::QuicDataWriter*)\ngwp_clang_tidy_num_overlapping_findings: 6\ngwp_clang_tidy_call: quic::QuicFramer::AppendIetfPacketHeader(quic::QuicPacketHeader const\u0026, quic::QuicDataWriter*, unsigned long*) -\u003e quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const\u0026) (590.613 gcus)\ngwp_clang_tidy_call: quic::QuicFramer::BuildIetfVersionNegotiationPacket(bool, quic::QuicConnectionId, quic::QuicConnectionId, std::__u::vector\u003cquic::ParsedQuicVersion, std::__u::allocator\u003cquic::ParsedQuicVersion\u003e\u003e const\u0026) -\u003e quic::QuicConnectionId::~QuicConnectionId() (0.0511007 gcus)\ngwp_clang_tidy_call: quic::QuicFramer::BuildDataPacket(quic::QuicPacketHeader const\u0026, absl::InlinedVector\u003cquic::QuicFrame, 1ul, std::__u::allocator\u003cquic::QuicFrame\u003e\u003e const\u0026, char*, unsigned long, quic::EncryptionLevel) -\u003e quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const\u0026) (3.16413 gcus)\ngwp_clang_tidy_call: quic::QuicFramer::BuildIetfVersionNegotiationPacket(bool, quic::QuicConnectionId, quic::QuicConnectionId, std::__u::vector\u003cquic::ParsedQuicVersion, std::__u::allocator\u003cquic::ParsedQuicVersion\u003e\u003e const\u0026) -\u003e quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const\u0026) (0.215968 gcus)\ngwp_clang_tidy_call: quic::QuicFramer::WriteClientVersionNegotiationProbePacket(char*, unsigned long, char const*, unsigned char) -\u003e quic::QuicConnectionId::~QuicConnectionId() (0.0205518 gcus)\ngwp_clang_tidy_call: quic::QuicFramer::WriteClientVersionNegotiationProbePacket(char*, unsigned long, char const*, unsigned char) -\u003e quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const\u0026) (0.128068 gcus)\ngwp_clang_tidy_call: quic::QuicFramer::AppendIetfPacketHeader(quic::QuicPacketHeader const\u0026, quic::QuicDataWriter*, unsigned long*) -\u003e quic::QuicConnectionId::~QuicConnectionId() (73.0821 gcus)\ngwp_clang_tidy_type_name: class quic::QuicConnectionId\ngwp_clang_tidy_check: google3-custom-unnecessary-value-param\n```\n\nTested:\n    http://test/OCL:713980267:BASE:715300728:1736851372677:caa9282b\n    Some test failures are present; the CL author decided to mail\nPiperOrigin-RevId: 715386954\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "32a54dd5daf39f85d1adc353bae7e9cd934e759c",
      "old_mode": 33188,
      "old_path": "quiche/quic/core/quic_framer.cc",
      "new_id": "1cddd907316fad978a514cf1ae0cc51609e2c8d3",
      "new_mode": 33188,
      "new_path": "quiche/quic/core/quic_framer.cc"
    }
  ]
}