)]}'
{
  "commit": "92df092e075e98ab07e810c3e24a9078f687c8e8",
  "tree": "565c5fbd21c26f1d194b745525a9f42c0b206140",
  "parents": [
    "0142a09c2f0c8bb48f2aa13ec375f5e3287ad2e6"
  ],
  "author": {
    "name": "bnc",
    "email": "bnc@google.com",
    "time": "Tue Apr 27 14:23:39 2021 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Apr 27 14:24:14 2021 -0700"
  },
  "message": "Signal error on PUSH_PROMISE and CANCEL_PUSH frames.\n\nSince HttpEncoder is not capable of sending MAX_PUSH_ID frames, receiving these\nframes is a violation of the spec.\n\nFor simplicity, use the error code H3_FRAME_ERROR.  This is incorrect, because\nreceiving a PUSH_PROMISE frame by the client on the control stream, or\nreceiving a CANCEL_PUSH frame either by the client or by the server on the control\nstream should trigger an H3_ID_ERROR, and these frames in other cases should\ntrigger a H3_FRAME_UNEXPECTED error.  However, it is expected to be exceedingly\nrare for any endpoint to send such frames without receiving a MAX_PUSH_ID frame,\nso the error code does not matter as much as actually closing the connection.\n\nProtected by FLAGS_quic_reloadable_flag_quic_error_on_http3_push.\n\nPiperOrigin-RevId: 370762371\nChange-Id: I18d4d29e95faf9919858bada73ef0b5912afbd8b\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "859d174b30c3c401873d915064f0110de8ee462d",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_decoder.cc",
      "new_id": "6d9290a12c1e667519487d9ae2abc93ff158d6b4",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_decoder.cc"
    },
    {
      "type": "modify",
      "old_id": "5580d447f87a00e7289eb9c2538af7042f82f88e",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_decoder.h",
      "new_id": "3a970fb63b14cdade88b5201e82eae23009c987f",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_decoder.h"
    },
    {
      "type": "modify",
      "old_id": "ab0e31ff67a560d6a84063ac42c193cbbe44b9c3",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_decoder_test.cc",
      "new_id": "95c1c5cf88f0462ef3bfdd168be941a65b16df68",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_decoder_test.cc"
    },
    {
      "type": "modify",
      "old_id": "fbd7b2eb18e68715206184ebaff501230435a489",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_receive_control_stream.cc",
      "new_id": "83a894078fd0bc9b6251bac234a26dbf63a9f8f7",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_receive_control_stream.cc"
    },
    {
      "type": "modify",
      "old_id": "1c24808d25da852654961a2141adba28a6480b51",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_receive_control_stream_test.cc",
      "new_id": "b81d0ba1549d83422b9ad4afe0e8a079d4e3bf06",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_receive_control_stream_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c638a0a0b3a698b7e822be65e704f5c499887d55",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_session_test.cc",
      "new_id": "dbf5def9a60f8fdfed9e4b5b917eb4748add7047",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_session_test.cc"
    },
    {
      "type": "modify",
      "old_id": "bb464bdb4d568aeb5af91b8fc274d3c458978e9a",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_stream_test.cc",
      "new_id": "8b814b8400b434fc4674ec9c784c92efd46da4da",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_stream_test.cc"
    },
    {
      "type": "modify",
      "old_id": "32816b869cf1f962760fd0f22fffa7622dee9758",
      "old_mode": 33188,
      "old_path": "quic/core/quic_error_codes.h",
      "new_id": "9fa422f578c80654c93a082059184f0b2a11d7de",
      "new_mode": 33188,
      "new_path": "quic/core/quic_error_codes.h"
    },
    {
      "type": "modify",
      "old_id": "3f7ca67af2bd7c3fababd387587f7892ce93d56e",
      "old_mode": 33188,
      "old_path": "quic/core/quic_flags_list.h",
      "new_id": "4ed13ff15509c5f8ac7e0c1927a4c75e27d03614",
      "new_mode": 33188,
      "new_path": "quic/core/quic_flags_list.h"
    }
  ]
}
