)]}'
{
  "commit": "7e427ee26c83f243ca49c2c5fabbc6b004a4d21c",
  "tree": "d63a7747b8ab31bcc73c538bd059fc44a119dd7a",
  "parents": [
    "bbd2d8c8890f3c21f268e9037b0e23dbc64d58e0"
  ],
  "author": {
    "name": "davidben",
    "email": "davidben@google.com",
    "time": "Wed Nov 20 14:13:34 2024 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Nov 20 14:14:30 2024 -0800"
  },
  "message": "Remove ResumptionAttempted assertion in TlsServerHandshakerTest.ResumptionWithPlaceholderTicket\n\nThis is a bit of a mess. QUICHE started sending a placeholder ticket when ticket encryption failed, because it used to return an empty string, which was not actually valid. However, the flag was not consistently enabled, so sometimes the test ran with the old empty string.\n\nBoringSSL happened not to notice, but newer BoringSSL clients catch this. However, newer BoringSSL servers, as of https://boringssl.googlesource.com/boringssl/+/c59bf8bf189dcbde868e04efcd53b705ed155231, now also support empty string as a signal to skip sending a ticket. That is actually the ideal behavior for QUICHE in this situation.\n\nHowever, the tests actually reject the ideal behavior because they assert that `ResumptionAttempted()` is true. Remove the assertion so that QUICHE, with the flag on or off, is compatible with the newest BoringSSL.\n\nPiperOrigin-RevId: 698517697\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "855d09267630b4ff4d2682210470763bc69b39ac",
      "old_mode": 33188,
      "old_path": "quiche/quic/core/tls_server_handshaker_test.cc",
      "new_id": "ca00b644f19238c0b7f4830ef0c8e5a46d9bb227",
      "new_mode": 33188,
      "new_path": "quiche/quic/core/tls_server_handshaker_test.cc"
    }
  ]
}