tree 37c7e8b9f8ab02324d23787dc387bdf5a52feaa2
parent 83c586a2af1ad6b73c84917d5d7deb69dfc3eea1
author QUICHE team <quiche-dev@google.com> 1594148610 -0700
committer Copybara-Service <copybara-worker@google.com> 1594148641 -0700

Don’t assume `QuicheStringPiece::const_iterator` is a `const char*`

Explicitly convert a `QuicheStringPiece::const_iterator` to `const char*` before trying to initialize a `QuicheStringPiece` with it. This is technically required by the standard – `std::string_view` (to which `QuicheStringPiece` decays in C++17 mode) only has

std::string_view::string_view(const char*, size_t);
std::string_view::string_view(const char*);

and not

std::string_view::string_view(std::string_view::const_iterator);

In practice, this isn’t generally an issue, because most STL implementations use `const char*` as the `string_view` iterator type. MSVC, however, uses a struct for the iterator and therefore requires the explicit conversion.

Thanks go to Yifan Yang <needyyang@google.com>, who identified this issue.

PiperOrigin-RevId: 320031927
Change-Id: If81aff793fac2db7202b5df0d02f86147fc3a658