commit 4900f496b26a78c993c971a1717abb6c82b397ae
author QUICHE team <quiche-dev@google.com> Mon Jan 31 14:30:12 2022 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Jan 31 14:30:59 2022 -0800
tree 05b0c574d5459cebd74a11f89b37db6c643be82b
parent 816038db9cd9a4d8ceff34d66a26a059f7118fc0

Only creates a RecordingHeadersHandler when trace logging is enabled.

Previously, a RecordingHeadersHandler was created for every stream, whether trace logging was enabled or not. In the (common) case where trace logging was disabled, the headers handler would still copy every header block, wasting CPU.

Protected by existing flag --http2_trace_logging.

PiperOrigin-RevId: 425462990

http2/core/http2_trace_logging.cc

diff --git a/http2/core/http2_trace_logging.cc b/http2/core/http2_trace_logging.cc
index 2c1bee3..f8f54b6 100644
--- a/http2/core/http2_trace_logging.cc
+++ b/http2/core/http2_trace_logging.cc
@@ -189,9 +189,13 @@
       << FORMAT_ARG(stream_id);
   spdy::SpdyHeadersHandlerInterface* result =
       wrapped_->OnHeaderFrameStart(stream_id);
-  recording_headers_handler_ =
-      absl::make_unique<spdy::RecordingHeadersHandler>(result);
-  result = recording_headers_handler_.get();
+  if (is_enabled_()) {
+    recording_headers_handler_ =
+        absl::make_unique<spdy::RecordingHeadersHandler>(result);
+    result = recording_headers_handler_.get();
+  } else {
+    recording_headers_handler_ = nullptr;
+  }
   return result;
 }
 
@@ -328,7 +332,8 @@
 
 void Http2TraceLogger::LogReceivedHeaders() const {
   if (recording_headers_handler_ == nullptr) {
-    QUICHE_BUG(bug_2794_1) << "Cannot log headers before creating handler.";
+    // Trace logging was not enabled when the start of the header block was
+    // received.
     return;
   }
   HTTP2_TRACE_LOG(perspective_, is_enabled_)