)]}'
{
  "commit": "2ea28b21c71b7b1069dbff77252c9abf36f00c95",
  "tree": "8207243511fd5b08ee8b98d940e198e239faca13",
  "parents": [
    "6f580e900d2531ff57acd8f4bc214f7e54df5815"
  ],
  "author": {
    "name": "QUICHE team",
    "email": "quiche-dev@google.com",
    "time": "Wed Oct 27 10:10:08 2021 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Oct 27 10:11:08 2021 -0700"
  },
  "message": "Automatically send PING acks by default in OgHttp2Session.\n\nThis CL allows OgHttp2Session to automatically enqueue PING ack frames in\nresponse to receiving non-ack PINGs from its peer. Note that OgHttp2Session\nalready automatically enqueues SETTINGS ack frames:\nhttp://google3/third_party/http2/adapter/oghttp2_session.cc;l\u003d843-845;rcl\u003d403185538.\n\nThis PING ack addition aligns OgHttp2Session with default nghttp2 behavior.\nThis CL also adds an option to OgHttp2Session::Options to disable automatic\nPING acks, analogous to nghttp2_option_set_no_auto_ping_ack().\n\nThe default automatic PING acks are helpful in Envoy\u0027s frame flood detection\ntests. With this CL, the following four tests now pass with oghttp2 migration\ncl/392724171, as hypothesized/hoped for in http://b/201799377#comment2:\n  - Http2FloodMitigationTest.UpstreamFloodDetectionIsOnByDefault\n    http://sponge2/c75a3080-9839-4d4c-8ed6-4ad33a1d4aa5\n  - Http2FloodMitigationTest.UpstreamPingFlood\n    http://sponge2/64cb3358-31f5-4b6e-b94c-bd7082c49fd4\n  - Http2FloodMitigationTest.UpstreamRstStreamOnStreamIdleTimeout\n    http://sponge2/bb3585d3-ed50-4b2b-8d87-9123b6baa9ba\n  - Http2FloodMitigationTest.UpstreamRstStreamOnDownstreamRemoteClose\n    http://sponge2/34466067-2445-45ae-8cf8-61924a0f8d85\n\nPiperOrigin-RevId: 405915725\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8e3aa6de81e17206e6823e2728894f92af40b9be",
      "old_mode": 33188,
      "old_path": "http2/adapter/nghttp2_adapter_test.cc",
      "new_id": "03e2629a7be9bae94987db9ee309879925d8e223",
      "new_mode": 33188,
      "new_path": "http2/adapter/nghttp2_adapter_test.cc"
    },
    {
      "type": "modify",
      "old_id": "4b19874b678fbc133ae4b4a90dab2a9562394378",
      "old_mode": 33188,
      "old_path": "http2/adapter/oghttp2_adapter_test.cc",
      "new_id": "2fe13fd8ae9e2e685d98954cee1bd878a7f638f8",
      "new_mode": 33188,
      "new_path": "http2/adapter/oghttp2_adapter_test.cc"
    },
    {
      "type": "modify",
      "old_id": "dd1a987b87fde70a16033144e9fb6082e7796693",
      "old_mode": 33188,
      "old_path": "http2/adapter/oghttp2_session.cc",
      "new_id": "fe842301b07e7ad175c814c37b19cad9e4f6a7e1",
      "new_mode": 33188,
      "new_path": "http2/adapter/oghttp2_session.cc"
    },
    {
      "type": "modify",
      "old_id": "40a142bfa30b6aeed7f6fc61aa889cf9f0dc0c61",
      "old_mode": 33188,
      "old_path": "http2/adapter/oghttp2_session.h",
      "new_id": "3baf7ddba7ea81700fb39f5eda4effc18366f944",
      "new_mode": 33188,
      "new_path": "http2/adapter/oghttp2_session.h"
    },
    {
      "type": "modify",
      "old_id": "8951273e7205b03ef8a523363af54772af4128d2",
      "old_mode": 33188,
      "old_path": "http2/adapter/oghttp2_session_test.cc",
      "new_id": "b4b464be72c90bb53ddaed34e2632ab8da4af54e",
      "new_mode": 33188,
      "new_path": "http2/adapter/oghttp2_session_test.cc"
    }
  ]
}