tree f71fc795845b031fdd6e104837e96052b72e3801
parent 40fb718495e85c2cf1a070a804ab851c3adc457f
author QUICHE team <quiche-dev@google.com> 1646856269 -0800
committer Copybara-Service <copybara-worker@google.com> 1646856343 -0800

Add testing for connection window flow control violations.

This CL adds oghttp2 and nghttp2 tests for the following scenario:
  1. Server sends SETTINGS with a MAX_FRAME_SIZE value greater than the initial
     connection flow control window.
  2. Client sends a request with a DATA frame payload of the MAX_FRAME_SIZE.

The server should recognize that the client-sent DATA frame induces a
connection-level flow control error, and should send a GOAWAY.

[NGHTTP2]
Indeed, nghttp2 recognizes this error correctly when the DATA frame is
processed all at once. However, nghttp2 does not recognize this error when the
DATA frame is processed in multiple ProcessBytes() calls.

[OGHTTP2]
It is likely that oghttp2 would recognize the flow control error [*], but
oghttp2 does not handle outbound MAX_FRAME_SIZE. Thus, oghttp2 currently
GOAWAYs prematurely before exercising flow control validation. Addressing the
MAX_FRAME_SIZE feature gap will be the work of b/223471995.

This testing was inspired by attempts to enable GFE2 HTTP/2 flow control e2e
testing for GFE3 (WIP with pending cl/433228245).

[*] http://google3/third_party/http2/adapter/oghttp2_session.cc;l=1042-1049;rcl=432298189

PiperOrigin-RevId: 433539997