)]}'
{
  "commit": "200d4708860fcb5f5510092b24391072901e7f17",
  "tree": "a4e79fad2d995a64d18b6708a66421672749a557",
  "parents": [
    "571f4ec55061f73ae6b7557a26b582bce09c8acc"
  ],
  "author": {
    "name": "martinduke",
    "email": "martinduke@google.com",
    "time": "Wed Nov 13 15:27:05 2024 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Nov 13 15:28:07 2024 -0800"
  },
  "message": "Update ECN tests to function properly in Guitar.\n\ncl/695874210, while deprecating the previous flag protection for send-side ECN, identified a particular block of code as relatively high-risk and so protected it with flag quic_preserve_dscp_with_ecn. Unfortunately, the code that executes when this flag is false does not correctly set the ECN bits when a test is running on Guitar (which uses GOOGLE_IP_TOS), causing failures.\n\nThis CL deletes the flag, and protects the entire code block by only executing it when packet_info.ecn_codepoint is not NOT_ECT (which never happens in production today).\n\nTests now pass in Guitar.\n\nPiperOrigin-RevId: 696290469\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fab0f088932393d330f22c7250655bf96c216a9c",
      "old_mode": 33261,
      "old_path": "quiche/common/quiche_feature_flags_list.h",
      "new_id": "09bf65343576a21787c57a3d55289aa484666e8f",
      "new_mode": 33261,
      "new_path": "quiche/common/quiche_feature_flags_list.h"
    },
    {
      "type": "modify",
      "old_id": "cbcfbbdfbabf89fba254fd69f6e6c8c14c5e573d",
      "old_mode": 33188,
      "old_path": "quiche/quic/core/quic_udp_socket_posix.inc",
      "new_id": "c368f2b7d774ca6b9f14ed4f763f94fc1eb76410",
      "new_mode": 33188,
      "new_path": "quiche/quic/core/quic_udp_socket_posix.inc"
    }
  ]
}