)]}' { "commit": "07a2b0784bcb03638b7728c610b1aef5a4e86b03", "tree": "8e1ee7ff975116d221c37bb712ec44cd230f2e8b", "parents": [ "b38e635502035083ead0d64e26026ee724238c65" ], "author": { "name": "wub", "email": "wub@google.com", "time": "Thu Oct 24 11:23:20 2019 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 24 11:24:00 2019 -0700" }, "message": "Fix 26 ClangTidy - Readability findings in //depot/google3/third_party/quic/.\n\nThese fixes are automatically created by various analysis tools, but their application in this CL has been manually triggered. See go/code-findings-fixes.\n\n* redundant get() call on smart pointer (11 times)\n* using decl \u0027Perspective\u0027 is unused\n* using decl \u0027SETTINGS_MAX_HEADER_LIST_SIZE\u0027 is unused (2 times)\n* using decl \u0027AtLeast\u0027 is unused\n* using decl \u0027SpdySettingsIR\u0027 is unused\n* using decl \u0027Pair\u0027 is unused\n* using decl \u0027UnorderedElementsAre\u0027 is unused\n* using decl \u0027Values\u0027 is unused\n* using decl \u0027Combine\u0027 is unused\n* using decl \u0027Invoke\u0027 is unused\n* lambda capture \u0027this\u0027 is not used (4 times)\n* using decl \u0027QuicSocketAddress\u0027 is unused\n\nPiperOrigin-RevId: 276529025\nChange-Id: Icee20b5bab6c9d8cc6c95b74594469257e791cb0\n", "tree_diff": [ { "type": "modify", "old_id": "dd8a680ec324886e4c746dc41ef20134539cf25e", "old_mode": 33188, "old_path": "quic/core/crypto/aes_128_gcm_12_decrypter_test.cc", "new_id": "9ce4bda19bab612d1f330703a8b7e2d24145d0df", "new_mode": 33188, "new_path": "quic/core/crypto/aes_128_gcm_12_decrypter_test.cc" }, { "type": "modify", "old_id": "54793f8c6e2fea18f6286a57849fcbaf613390a2", "old_mode": 33188, "old_path": "quic/core/crypto/aes_128_gcm_decrypter_test.cc", "new_id": "579f76d498de6b4e770e044b83bde37a59720a1f", "new_mode": 33188, "new_path": "quic/core/crypto/aes_128_gcm_decrypter_test.cc" }, { "type": "modify", "old_id": "73a3b3deec4e39b221402103fa7d3ed3c9484c3a", "old_mode": 33188, "old_path": "quic/core/crypto/aes_256_gcm_decrypter_test.cc", "new_id": "b3d61c7798f9be33416834deedcf07ece673a38e", "new_mode": 33188, "new_path": "quic/core/crypto/aes_256_gcm_decrypter_test.cc" }, { "type": "modify", "old_id": "a9c4999683b1ee51d33a0cbe322ccdf0270adda9", "old_mode": 33188, "old_path": "quic/core/crypto/chacha20_poly1305_decrypter_test.cc", "new_id": "930af24a3b371494f88bbd884de22dd88f3ac548", "new_mode": 33188, "new_path": "quic/core/crypto/chacha20_poly1305_decrypter_test.cc" }, { "type": "modify", "old_id": "ce4dea9f3855e51b9390dfdf4946eefca1d2d0ce", "old_mode": 33188, "old_path": "quic/core/crypto/chacha20_poly1305_tls_decrypter_test.cc", "new_id": "90052d60520f43a24f2589884a668f60ce67d3e1", "new_mode": 33188, "new_path": "quic/core/crypto/chacha20_poly1305_tls_decrypter_test.cc" }, { "type": "modify", "old_id": "022a86b922782dd8cbffc704ad775437add6b51e", "old_mode": 33188, "old_path": "quic/core/crypto/crypto_handshake_message.cc", "new_id": "762a279124c1dc8e747217be01cd655ef72172f4", "new_mode": 33188, "new_path": "quic/core/crypto/crypto_handshake_message.cc" }, { "type": "modify", "old_id": "ecbcab82e531599ed0e950a9ac94f17a3faedab3", "old_mode": 33188, "old_path": "quic/core/crypto/crypto_message_printer_bin.cc", "new_id": "67cd531dd72465e064aa4d99bb945a034f2ea4a7", "new_mode": 33188, "new_path": "quic/core/crypto/crypto_message_printer_bin.cc" }, { "type": "modify", "old_id": "75b2e6a2884858b42b52600c65a029c0e62b6c1d", "old_mode": 33188, "old_path": "quic/core/crypto/quic_crypto_client_config.cc", "new_id": "6813f7c2405e9bf7c06cc6b253d7daf1c3b51a5a", "new_mode": 33188, "new_path": "quic/core/crypto/quic_crypto_client_config.cc" }, { "type": "modify", "old_id": "c211cdb3345016fc139cd4b77283fb1f78907d25", "old_mode": 33188, "old_path": "quic/core/crypto/quic_crypto_server_config.cc", "new_id": "c23cf0fdca161ecc1d174c9c8eb622ceac0c61bc", "new_mode": 33188, "new_path": "quic/core/crypto/quic_crypto_server_config.cc" }, { "type": "modify", "old_id": "cbb4ca86b6c036696fb91177f091dad910b62e00", "old_mode": 33188, "old_path": "quic/core/http/end_to_end_test.cc", "new_id": "e39b90aeaa3c8aa849e77fcf49eb0a249cbb0d61", "new_mode": 33188, "new_path": "quic/core/http/end_to_end_test.cc" }, { "type": "modify", "old_id": "83acfe7e2731d984d2fedf5b2a49b0fcd2ff1e2c", "old_mode": 33188, "old_path": "quic/core/http/quic_headers_stream_test.cc", "new_id": "2e6b72964dc7f796fc194adf272bbab2c00a94b6", "new_mode": 33188, "new_path": "quic/core/http/quic_headers_stream_test.cc" }, { "type": "modify", "old_id": "c8df8a0c27de6e90b2145ea809db703a9ac94c81", "old_mode": 33188, "old_path": "quic/core/http/quic_receive_control_stream_test.cc", "new_id": "737451340824c8879de4e11db791807d7ab9b636", "new_mode": 33188, "new_path": "quic/core/http/quic_receive_control_stream_test.cc" }, { "type": "modify", "old_id": "8b42a90cdcdbda8efbb0ec782f70fdcb1a5ff433", "old_mode": 33188, "old_path": "quic/core/http/quic_spdy_session.cc", "new_id": "064f403625c730973e2fa746ffe08a10c0978833", "new_mode": 33188, "new_path": "quic/core/http/quic_spdy_session.cc" }, { "type": "modify", "old_id": "72d4a25ed137fd491ee1e4039cd4dce30e6ca90c", "old_mode": 33188, "old_path": "quic/core/http/spdy_server_push_utils_test.cc", "new_id": "0f6ec8a6287bfec2ec2634e2c54fd54c3720d03c", "new_mode": 33188, "new_path": "quic/core/http/spdy_server_push_utils_test.cc" }, { "type": "modify", "old_id": "0d172cd68470155d5e88a3a703b1ba9992f4770e", "old_mode": 33188, "old_path": "quic/core/qpack/qpack_instruction_encoder_test.cc", "new_id": "abd1353608676e4139981e1555deb494c0356032", "new_mode": 33188, "new_path": "quic/core/qpack/qpack_instruction_encoder_test.cc" }, { "type": "modify", "old_id": "567676c75d27ffa406830006012e481060c392c7", "old_mode": 33188, "old_path": "quic/core/qpack/qpack_round_trip_test.cc", "new_id": "cb2c51446e954efaef7783bc66e968f30faa7380", "new_mode": 33188, "new_path": "quic/core/qpack/qpack_round_trip_test.cc" }, { "type": "modify", "old_id": "2d4d4a5af8291a97167fcd38d62fecbe7db5ed05", "old_mode": 33188, "old_path": "quic/core/quic_framer.cc", "new_id": "b219042eac964acf4023b1929e32859899590965", "new_mode": 33188, "new_path": "quic/core/quic_framer.cc" }, { "type": "modify", "old_id": "7b7fb1a9e72865435999c2c6b4ecbc9e816cf97c", "old_mode": 33188, "old_path": "quic/core/quic_stream_id_manager_test.cc", "new_id": "2ff55be857ce8dde6b80446db20c3ebb023843b5", "new_mode": 33188, "new_path": "quic/core/quic_stream_id_manager_test.cc" }, { "type": "modify", "old_id": "7bd5f6b8563e68dfb44668a821ac979e8d250f43", "old_mode": 33188, "old_path": "quic/qbone/platform/netlink_test.cc", "new_id": "04ce68cd9a958450e8f843591c3db673629a78f0", "new_mode": 33188, "new_path": "quic/qbone/platform/netlink_test.cc" }, { "type": "modify", "old_id": "dee951efffc944897aaf82a74fbbc251ce224ea6", "old_mode": 33188, "old_path": "quic/qbone/qbone_session_test.cc", "new_id": "8a12ceced0b86f3ec56589ded374eaf71d795902", "new_mode": 33188, "new_path": "quic/qbone/qbone_session_test.cc" }, { "type": "modify", "old_id": "a9a3886af6e3e6c6827fa5c6338ee2c2be28cb86", "old_mode": 33188, "old_path": "quic/tools/quic_toy_client.cc", "new_id": "4159735928068d720ed44b71b181c196de929d9c", "new_mode": 33188, "new_path": "quic/tools/quic_toy_client.cc" } ] }