)]}'
{
  "commit": "fcd42350a9ee1016591c1ffc038fc28c12ffee96",
  "tree": "de7096a2e7b8a5acc63306f0b9916510bcad6384",
  "parents": [
    "f97492c63e718825e7d50d34bf383b70fb280f15"
  ],
  "author": {
    "name": "bnc",
    "email": "bnc@google.com",
    "time": "Fri Sep 20 17:55:47 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Sep 24 08:32:07 2019 -0700"
  },
  "message": "Signal error in HttpDecoder on empty PUSH_PROMISE frame.\n\nCurrently on an empty, invalid PUSH_PROMISE frame HttpDecoder transitions from\nSTATE_READING_FRAME_LENGTH directly to STATE_FINISH_PARSING, skipping\nSTATE_READING_FRAME_PAYLOAD, which results in calling\nVisitor::OnPushPromiseFrameEnd() without calling\nVisitor::OnPushPromiseFrameStart().  This is wrong and can cause QuicSpdyStream\nto crash.\n\nThis was caught by ClusterFuzz at https://crbug.com/1001823.\n\nAlso add tests for other empty frames, and sanity DCHECKs in QuicSpdyStream.\n\ngfe-relnote: n/a, change to QUIC v99-only code.  Protected by existing disabled\ngfe2_reloadable_flag_quic_enable_version_99.\nPiperOrigin-RevId: 270386637\nChange-Id: I0c1944d1df300136d27367679e3128dd45e9bfd3\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c9519fe49a46d736089bff5cba3f10c8f977852c",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_decoder.cc",
      "new_id": "e1fa36e71dd656f3b06f9816f6f6a0856754a0ae",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_decoder.cc"
    },
    {
      "type": "modify",
      "old_id": "6847ecbf82b6975c288e8ed6b75f4d8a28f9a67b",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_decoder_test.cc",
      "new_id": "3abc8beb154633e9653ae57ee16ea09c4cb7f62e",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_decoder_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a407d5cf83d67a3f032dfa9adb03eec501d53151",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_stream.cc",
      "new_id": "a08934573210bfae5a8bc7b55c9a5624f1c4315c",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_stream.cc"
    }
  ]
}