)]}'
{
  "commit": "f7c6a91b0bf25917496afe2c29945ab517bb1c93",
  "tree": "42914356e9c0daa5c1730ab43d557a543db8feaf",
  "parents": [
    "8373d1729dd36da00a7988f066bd220460f91ba7"
  ],
  "author": {
    "name": "dschinazi",
    "email": "dschinazi@google.com",
    "time": "Tue May 05 11:39:53 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue May 05 11:40:38 2020 -0700"
  },
  "message": "Remove QuicNegotiableValue\n\nThis CL reimplements QUIC idle timeout negotiation without QuicNegotiableValue, and removes QuicNegotiableValue. QuicNegotiableValue is considered overly complex and hard to understand and use correctly, and has caused bugs in the past. Idle timeout was the only user of it, so reusing QuicFixedUint32 and bespoke handling was the simplest option. The wire format for idle timeout is unchanged by this CL: it\u0027s still encoded as a 32bit integer in seconds for QUIC_CRYPTO and a 62bit integer in milliseconds for QUIC+TLS. Therefore this CL does not change any behavior.\n\ngfe-relnote: refactor idle timeout, no behavior change, not flag protected\n\nStartblock:\n  after 2020-05-05 09:00 in US/Pacific\nPiperOrigin-RevId: 309988666\nChange-Id: I67ae7caad8ec73c05e27c8e49d940a2393d4b2df\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "644c8f067bfa3d35c861a695eb899cf9dc316fd5",
      "old_mode": 33188,
      "old_path": "quic/core/quic_config.cc",
      "new_id": "25087641412632f8ea777315f1492b874b17dc13",
      "new_mode": 33188,
      "new_path": "quic/core/quic_config.cc"
    },
    {
      "type": "modify",
      "old_id": "a46af4da9ba39cc7e5aef0f36f095ac6a1012f03",
      "old_mode": 33188,
      "old_path": "quic/core/quic_config.h",
      "new_id": "a968369a83f6f49c553e18288f0832afbbecda59",
      "new_mode": 33188,
      "new_path": "quic/core/quic_config.h"
    },
    {
      "type": "modify",
      "old_id": "cb8d3be0b6a5fc6da84f6f4dfc53349c6ea61a16",
      "old_mode": 33188,
      "old_path": "quic/core/quic_config_test.cc",
      "new_id": "8671d7ed9a2050cf2fd806c034ee17e10f9cf359",
      "new_mode": 33188,
      "new_path": "quic/core/quic_config_test.cc"
    },
    {
      "type": "modify",
      "old_id": "8b6f75207bce7dd70120ff28f5e7f5750c4c4154",
      "old_mode": 33188,
      "old_path": "quic/core/quic_connection_test.cc",
      "new_id": "613358a87ebf9d885df4e38b9045da482741fc24",
      "new_mode": 33188,
      "new_path": "quic/core/quic_connection_test.cc"
    },
    {
      "type": "modify",
      "old_id": "7b4c9f922ce0d1c3b8aaa4d38d5926ee32732267",
      "old_mode": 33188,
      "old_path": "quic/test_tools/quic_config_peer.cc",
      "new_id": "2f20e9528f9d65af9499327483aa2651fae18767",
      "new_mode": 33188,
      "new_path": "quic/test_tools/quic_config_peer.cc"
    },
    {
      "type": "modify",
      "old_id": "5ce7a0448cd248b9e57b17b172c72b47084eab19",
      "old_mode": 33188,
      "old_path": "quic/test_tools/quic_config_peer.h",
      "new_id": "64d4d1e5f3b78d4ca0f37119c2f15310baa416ea",
      "new_mode": 33188,
      "new_path": "quic/test_tools/quic_config_peer.h"
    }
  ]
}