)]}'
{
  "commit": "b6880f79b56f38c05be91191f9630e9aa66ecc2d",
  "tree": "0644278615c93bb4446c30310017f4a41e3603c1",
  "parents": [
    "c5db41e3e5d07c019e556964e5bbeb891e5b70fd"
  ],
  "author": {
    "name": "rch",
    "email": "rch@google.com",
    "time": "Wed Mar 06 12:06:07 2019 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Mar 06 12:06:29 2019 -0800"
  },
  "message": "hpack_whole_entry_buffer_test: Include http2_test_helpers.h\n\nThis fixes the GCC build, which was failing with\n\n../../third_party/googletest/src/googlemock/include/gmock/gmock-matchers.h: In instantiation of ?bool testing::internal::HasSubstrMatcher\u003cStringType\u003e::MatchAndExplain(const MatcheeStringType\u0026, testing::MatchResultListener*) const [with MatcheeStringType \u003d base::BasicStringPiece\u003cstd::__cxx11::basic_string\u003cchar\u003e \u003e; StringType \u003d std::__cxx11::basic_string\u003cchar\u003e]?:\n../../third_party/googletest/src/googletest/include/gtest/gtest-matchers.h:548:47:   required from ?bool testing::PolymorphicMatcher\u003cImpl\u003e::MonomorphicImpl\u003cT\u003e::MatchAndExplain(T, testing::MatchResultListener*) const [with T \u003d const base::BasicStringPiece\u003cstd::__cxx11::basic_string\u003cchar\u003e \u003e\u0026; Impl \u003d testing::internal::HasSubstrMatcher\u003cstd::__cxx11::basic_string\u003cchar\u003e \u003e]?\n../../third_party/googletest/src/googletest/include/gtest/gtest-matchers.h:547:18:   required from here\n../../third_party/googletest/src/googlemock/include/gmock/gmock-matchers.h:756:23: error: invalid initialization of reference of type ?const std::__cxx11::basic_string\u003cchar\u003e\u0026? from expression of type ?const base::BasicStringPiece\u003cstd::__cxx11::basic_string\u003cchar\u003e \u003e?\n     const StringType\u0026 s2(s);\n                       ^~\n\nThis is caused by the fact that base::StringPiece::operator std::string() is\nexplicit and thus StringPieces cannot be converted directly to an\nstd::string (GCC and MSVC fail to build a reduced version of this code,\nwhile ICC and clang allow it; in this case it looks like GCC is in the right\nhere).\n\nFix it by including http2_test_helpers.h, which contains a HasSubstr()\nspecialization precisely for this reason -- hpack_whole_entry_buffer_test.cc\nhad this HasSubstr() specialization before\nhttps://chromium-review.googlesource.com/c/1351102 (\"Platformize\nhttp2_bug_tracker.h, failure.h, std::deque and ABSL_DIE_IF_NULL\") moved it\nto a separate header that was not included by this file.\n\nCloned from https://quiche-review.googlesource.com/c/quiche/+/1500\n\ngfe-relnote: n/a - Test only\nPiperOrigin-RevId: 237093700\nChange-Id: Ife4efda0272011811506e0d2fd01be8221c66f9e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "75b281c062ddf42d96401376537d425de0a8dc3f",
      "old_mode": 33188,
      "old_path": "http2/hpack/decoder/hpack_whole_entry_buffer_test.cc",
      "new_id": "0265e9cdad106dd0d54c4484a4fc0b5c166d8fc0",
      "new_mode": 33188,
      "new_path": "http2/hpack/decoder/hpack_whole_entry_buffer_test.cc"
    }
  ]
}