)]}' { "commit": "b09d44167c543b80b2c27408dd1f9df3b07c9741", "tree": "b4b8008c379240b3efac345c156986252fb68b9c", "parents": [ "9addc9c8b8ef301a9a5ed7eaf59be9a2a1772846" ], "author": { "name": "bnc", "email": "bnc@google.com", "time": "Thu Oct 17 12:06:12 2019 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 17 12:06:45 2019 -0700" }, "message": "Do not track unacknowledged references on the encoder stream in QpackBlockingManager.\n\nThis CL essentially reverts change 263116461, which was an oversight on my part.\nThe reason is that unacknowledged references only have to be tracked so that no\nentry with unacknowledged references is evicted from the dynamic table.\nHowever, eviction is caused by an insertion on the encoder stream, and by that\ntime that is processed, it is guaranteed that every reference on the encoder\nstream sent before that insertion is already processed by the decoder. (And of\ncourse there can not be references on the encoder stream after the entry is\nevicted.) So references on the encoder stream do not matter, only references on\nother streams.\n\ngfe-relnote: n/a, change to QUIC v99-only code. Protected by existing disabled gfe2_reloadable_flag_quic_enable_version_99.\nPiperOrigin-RevId: 275309366\nChange-Id: Id3e4845f76815bc228b567fb55124a5d771843d9\n", "tree_diff": [ { "type": "modify", "old_id": "ffec17280f61fcc94638dab4d4d93e289d1efdb5", "old_mode": 33188, "old_path": "quic/core/qpack/qpack_blocking_manager.cc", "new_id": "3544f1ca10bbf5732d69b6cf72a461294fef325e", "new_mode": 33188, "new_path": "quic/core/qpack/qpack_blocking_manager.cc" }, { "type": "modify", "old_id": "60f7db7060a21b821346fe0c5e7333ba45a00eb3", "old_mode": 33188, "old_path": "quic/core/qpack/qpack_blocking_manager.h", "new_id": "6d2df9cfcf80f8837418cc9f53d3b757bdb780dc", "new_mode": 33188, "new_path": "quic/core/qpack/qpack_blocking_manager.h" }, { "type": "modify", "old_id": "64bfb97f71de2b7826ef87fac6012cfb215325c0", "old_mode": 33188, "old_path": "quic/core/qpack/qpack_blocking_manager_test.cc", "new_id": "d92dda549ef4bf57bb61384a1f01de26bd52c84a", "new_mode": 33188, "new_path": "quic/core/qpack/qpack_blocking_manager_test.cc" }, { "type": "modify", "old_id": "319af82115a289509bf8e5be46c5be43eea443a4", "old_mode": 33188, "old_path": "quic/core/qpack/qpack_encoder.cc", "new_id": "599c575b72342aca63eb91e08f06daa78256959f", "new_mode": 33188, "new_path": "quic/core/qpack/qpack_encoder.cc" } ] }