)]}'
{
  "commit": "acf863dc37b897ce1e4454b8eb46b67612778437",
  "tree": "8a6e9f6611ebaaf3afc2ba5d92a8a40d238baeaa",
  "parents": [
    "9a5d7c01a17655cbe730e6290a5451f0ca152451"
  ],
  "author": {
    "name": "dschinazi",
    "email": "dschinazi@google.com",
    "time": "Mon Feb 22 17:38:59 2021 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Mon Feb 22 17:40:50 2021 -0800"
  },
  "message": "Make QUIC insecure randomness thread-safe\n\ncl/358886449 accidentally causes undefined behavior by introducing insecure randomness in a thread-unsafe way, even though QuicRandom is expected to be thread-safe. This CL switches the random number generator state to thread_local storage to avoid the issue. This is slightly slower than before, but still 100x faster than secure randomness. This CL replaces the feature flag to ensure the thread-unsafe code does not get enabled.\n\nProtected by FLAGS_quic_reloadable_flag_quic_stateless_reset_faster_random.\n\nPiperOrigin-RevId: 358941810\nChange-Id: Ie00942a0fad3f459a9eeff1a32a34af73da7f5d0\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8292e9b58d7388cb34270a6b01e55d6b9325235e",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_random.cc",
      "new_id": "56657b507f96272f4c4199e4c670960bc35dc8e3",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_random.cc"
    },
    {
      "type": "modify",
      "old_id": "ff1c4bbf5018ca865c72a34055affe62f994d407",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_random.h",
      "new_id": "4d7bf943ac4f0768b0ec2918b307b62573d654c2",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_random.h"
    },
    {
      "type": "modify",
      "old_id": "9a88972833e7b5edb393ec9b9e90fb8c3535b7e6",
      "old_mode": 33188,
      "old_path": "quic/core/quic_flags_list.h",
      "new_id": "97930ff1ec50445fe9329bae695c714435d81f5b",
      "new_mode": 33188,
      "new_path": "quic/core/quic_flags_list.h"
    },
    {
      "type": "modify",
      "old_id": "432bd132f64fa3038f16dcb7252988e222faee93",
      "old_mode": 33188,
      "old_path": "quic/core/quic_framer.cc",
      "new_id": "fdccef9c72fa31e25fa3a2f68e660a4407c1c2d7",
      "new_mode": 33188,
      "new_path": "quic/core/quic_framer.cc"
    }
  ]
}
