tree 35767074060baf5e71dcddd8d77f33c746c514d0
parent bc02673d9ea4937cfec65dee62e95a9fca31239b
author bnc <bnc@google.com> 1651070326 -0700
committer Copybara-Service <copybara-worker@google.com> 1651070379 -0700

Make BalsaBuffer constructors public.

Constructors should be private when there is a public factory method for
creating the object, to prevent accidental instantiation not by the factory
method.  However, this is not the case with BalsaBuffer.  This class is
instantiated using its constructors by BalsaHeaders and in tests, and there
making the constructor public allows the removal of a forward declaration, two
friend declaration together with their comment, and another comment stating
"this is awkward".

Also while working on BalsaBuffer constructors, replace absl::WrapUnique(new)
with std::make_unique<>.

PiperOrigin-RevId: 444855708