)]}'
{
  "commit": "9ff4c26e5723669a8088c61cc07ecaf1a3bb5414",
  "tree": "4affd6fbe37d686cd0ab119699fe07f85925f338",
  "parents": [
    "9867b3b20d40a065c71c9147b90a2669a7c1a219"
  ],
  "author": {
    "name": "achernya",
    "email": "achernya@google.com",
    "time": "Fri Dec 02 12:28:47 2022 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri Dec 02 12:29:35 2022 -0800"
  },
  "message": "Produce correct ICMP6 Echo Reply when pinging magic link-local address\n\nBonnet\u0027s implementation of IcmpReachableInterface internally produces\nICMP6 Echo Requests directed at a link-local address that is\nreplied-to by the server directly, without relying on other network\nelements. However, we were previously constructing the ICMP6 Echo\nReply incorrectly, putting in the entire packet (as is expected for\nICMP errors) rather than its body.\n\nThis would produce non-sensical output when used with `ping6`, namely\n\n```\n# ping6 -i 0.1 fe80::71:626f:6e65%qbone0 -c 1\nPING fe80::71:626f:6e65%qbone0(fe80::71:626f:6e65) 56 data bytes\nWarning: time of day goes back (-3758166514911134782us), taking countermeasures.\nWarning: time of day goes back (-3758166514911134731us), taking countermeasures.\n112 bytes from 2002:a17:51a:2b52:b0:79c:f9be:5968: icmp_seq\u003d1 ttl\u003d255 time\u003d0.000 ms\nwrong data byte #16 should be 0x10 but was 0x0\n#16     0 0 0 0 0 0 0 0 fe 80 0 0 0 0 0 0 0 0 0 71 62 6f 6e 65 80 0 fa c3 3a fb 0 1\n#48     4f 53 8a 63 0 0 0 0\n\n--- fe80::71:626f:6e65%qbone0 ping statistics ---\n1 packets transmitted, 1 received, 0% packet loss, time 0ms\nrtt min/avg/max/mdev \u003d 0.000/0.000/0.000/0.000 ms\n```\n\nThis changes corrects the `body` passed through to actually be that of\nthe ICMP6 Echo Request, which includes both the UNIX timeval and the\ncounter of padding when using standard iputils ping6.\n\nThis is really an entirely cosmetic issue, but it should also fix the\nconfusion Wireshark has when looking at packet captures over QBONE,\nwhere it is not able to line up the request and reply since the data\ndon\u0027t match.\n\nPiperOrigin-RevId: 492531951\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "abf77d5a6632b963d804a2a0b82d09a1922fd6ac",
      "old_mode": 33188,
      "old_path": "quiche/quic/qbone/qbone_packet_processor.cc",
      "new_id": "be09ef2a0f2c9fda86221687191caa533d5be64f",
      "new_mode": 33188,
      "new_path": "quiche/quic/qbone/qbone_packet_processor.cc"
    },
    {
      "type": "modify",
      "old_id": "e11fd5cea588ba2b3187cc02301bac8716833e67",
      "old_mode": 33188,
      "old_path": "quiche/quic/qbone/qbone_packet_processor_test.cc",
      "new_id": "e416bb96965f53f73859e38cf637066f88bd54f5",
      "new_mode": 33188,
      "new_path": "quiche/quic/qbone/qbone_packet_processor_test.cc"
    }
  ]
}