| // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "quiche/quic/core/quic_stream_sequencer.h" |
| |
| #include <algorithm> |
| #include <cstdint> |
| #include <memory> |
| #include <string> |
| #include <utility> |
| #include <vector> |
| |
| #include "absl/base/macros.h" |
| #include "absl/strings/string_view.h" |
| #include "quiche/quic/core/quic_stream.h" |
| #include "quiche/quic/core/quic_utils.h" |
| #include "quiche/quic/platform/api/quic_expect_bug.h" |
| #include "quiche/quic/platform/api/quic_flags.h" |
| #include "quiche/quic/platform/api/quic_logging.h" |
| #include "quiche/quic/platform/api/quic_test.h" |
| #include "quiche/quic/test_tools/quic_stream_sequencer_peer.h" |
| #include "quiche/quic/test_tools/quic_test_utils.h" |
| |
| using testing::_; |
| using testing::AnyNumber; |
| using testing::InSequence; |
| |
| namespace quic { |
| namespace test { |
| |
| class MockStream : public QuicStreamSequencer::StreamInterface { |
| public: |
| MOCK_METHOD(void, OnFinRead, (), (override)); |
| MOCK_METHOD(void, OnDataAvailable, (), (override)); |
| MOCK_METHOD(void, OnUnrecoverableError, |
| (QuicErrorCode error, const std::string& details), (override)); |
| MOCK_METHOD(void, OnUnrecoverableError, |
| (QuicErrorCode error, QuicIetfTransportErrorCodes ietf_error, |
| const std::string& details), |
| (override)); |
| MOCK_METHOD(void, ResetWithError, (QuicResetStreamError error), (override)); |
| MOCK_METHOD(void, AddBytesConsumed, (QuicByteCount bytes), (override)); |
| |
| QuicStreamId id() const override { return 1; } |
| ParsedQuicVersion version() const override { |
| return CurrentSupportedVersions()[0]; |
| } |
| }; |
| |
| namespace { |
| |
| static const char kPayload[] = |
| "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"; |
| |
| class QuicStreamSequencerTest : public QuicTest { |
| public: |
| void ConsumeData(size_t num_bytes) { |
| char buffer[1024]; |
| ASSERT_GT(ABSL_ARRAYSIZE(buffer), num_bytes); |
| struct iovec iov; |
| iov.iov_base = buffer; |
| iov.iov_len = num_bytes; |
| ASSERT_EQ(num_bytes, sequencer_->Readv(&iov, 1)); |
| } |
| |
| protected: |
| QuicStreamSequencerTest() |
| : stream_(), sequencer_(new QuicStreamSequencer(&stream_)) {} |
| |
| // Verify that the data in first region match with the expected[0]. |
| bool VerifyReadableRegion(const std::vector<std::string>& expected) { |
| return VerifyReadableRegion(*sequencer_, expected); |
| } |
| |
| // Verify that the data in each of currently readable regions match with each |
| // item given in |expected|. |
| bool VerifyReadableRegions(const std::vector<std::string>& expected) { |
| return VerifyReadableRegions(*sequencer_, expected); |
| } |
| |
| bool VerifyIovecs(iovec* iovecs, size_t num_iovecs, |
| const std::vector<std::string>& expected) { |
| return VerifyIovecs(*sequencer_, iovecs, num_iovecs, expected); |
| } |
| |
| bool VerifyReadableRegion(const QuicStreamSequencer& sequencer, |
| const std::vector<std::string>& expected) { |
| iovec iovecs[1]; |
| if (sequencer.GetReadableRegions(iovecs, 1)) { |
| return (VerifyIovecs(sequencer, iovecs, 1, |
| std::vector<std::string>{expected[0]})); |
| } |
| return false; |
| } |
| |
| // Verify that the data in each of currently readable regions match with each |
| // item given in |expected|. |
| bool VerifyReadableRegions(const QuicStreamSequencer& sequencer, |
| const std::vector<std::string>& expected) { |
| iovec iovecs[5]; |
| size_t num_iovecs = |
| sequencer.GetReadableRegions(iovecs, ABSL_ARRAYSIZE(iovecs)); |
| return VerifyReadableRegion(sequencer, expected) && |
| VerifyIovecs(sequencer, iovecs, num_iovecs, expected); |
| } |
| |
| bool VerifyIovecs(const QuicStreamSequencer& /*sequencer*/, iovec* iovecs, |
| size_t num_iovecs, |
| const std::vector<std::string>& expected) { |
| int start_position = 0; |
| for (size_t i = 0; i < num_iovecs; ++i) { |
| if (!VerifyIovec(iovecs[i], |
| expected[0].substr(start_position, iovecs[i].iov_len))) { |
| return false; |
| } |
| start_position += iovecs[i].iov_len; |
| } |
| return true; |
| } |
| |
| bool VerifyIovec(const iovec& iovec, absl::string_view expected) { |
| if (iovec.iov_len != expected.length()) { |
| QUIC_LOG(ERROR) << "Invalid length: " << iovec.iov_len << " vs " |
| << expected.length(); |
| return false; |
| } |
| if (memcmp(iovec.iov_base, expected.data(), expected.length()) != 0) { |
| QUIC_LOG(ERROR) << "Invalid data: " << static_cast<char*>(iovec.iov_base) |
| << " vs " << expected; |
| return false; |
| } |
| return true; |
| } |
| |
| void OnFinFrame(QuicStreamOffset byte_offset, const char* data) { |
| QuicStreamFrame frame; |
| frame.stream_id = 1; |
| frame.offset = byte_offset; |
| frame.data_buffer = data; |
| frame.data_length = strlen(data); |
| frame.fin = true; |
| sequencer_->OnStreamFrame(frame); |
| } |
| |
| void OnFrame(QuicStreamOffset byte_offset, const char* data) { |
| QuicStreamFrame frame; |
| frame.stream_id = 1; |
| frame.offset = byte_offset; |
| frame.data_buffer = data; |
| frame.data_length = strlen(data); |
| frame.fin = false; |
| sequencer_->OnStreamFrame(frame); |
| } |
| |
| size_t NumBufferedBytes() { |
| return QuicStreamSequencerPeer::GetNumBufferedBytes(sequencer_.get()); |
| } |
| |
| testing::StrictMock<MockStream> stream_; |
| std::unique_ptr<QuicStreamSequencer> sequencer_; |
| }; |
| |
| // TODO(rch): reorder these tests so they build on each other. |
| |
| TEST_F(QuicStreamSequencerTest, RejectOldFrame) { |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(3); |
| })); |
| |
| OnFrame(0, "abc"); |
| |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| EXPECT_EQ(3u, sequencer_->NumBytesConsumed()); |
| // Ignore this - it matches a past packet number and we should not see it |
| // again. |
| OnFrame(0, "def"); |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, RejectBufferedFrame) { |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| |
| OnFrame(0, "abc"); |
| EXPECT_EQ(3u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| |
| // Ignore this - it matches a buffered frame. |
| // Right now there's no checking that the payload is consistent. |
| OnFrame(0, "def"); |
| EXPECT_EQ(3u, NumBufferedBytes()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, FullFrameConsumed) { |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(3); |
| })); |
| |
| OnFrame(0, "abc"); |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| EXPECT_EQ(3u, sequencer_->NumBytesConsumed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, BlockedThenFullFrameConsumed) { |
| sequencer_->SetBlockedUntilFlush(); |
| |
| OnFrame(0, "abc"); |
| EXPECT_EQ(3u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(3); |
| })); |
| sequencer_->SetUnblocked(); |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| EXPECT_EQ(3u, sequencer_->NumBytesConsumed()); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(3); |
| })); |
| EXPECT_FALSE(sequencer_->IsClosed()); |
| EXPECT_FALSE(sequencer_->IsAllDataAvailable()); |
| OnFinFrame(3, "def"); |
| EXPECT_TRUE(sequencer_->IsClosed()); |
| EXPECT_TRUE(sequencer_->IsAllDataAvailable()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, BlockedThenFullFrameAndFinConsumed) { |
| sequencer_->SetBlockedUntilFlush(); |
| |
| OnFinFrame(0, "abc"); |
| EXPECT_EQ(3u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(3); |
| })); |
| EXPECT_FALSE(sequencer_->IsClosed()); |
| EXPECT_TRUE(sequencer_->IsAllDataAvailable()); |
| sequencer_->SetUnblocked(); |
| EXPECT_TRUE(sequencer_->IsClosed()); |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| EXPECT_EQ(3u, sequencer_->NumBytesConsumed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, EmptyFrame) { |
| if (!stream_.version().HasIetfQuicFrames()) { |
| EXPECT_CALL(stream_, |
| OnUnrecoverableError(QUIC_EMPTY_STREAM_FRAME_NO_FIN, _)); |
| } |
| OnFrame(0, ""); |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, EmptyFinFrame) { |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| OnFinFrame(0, ""); |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| EXPECT_TRUE(sequencer_->IsAllDataAvailable()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, PartialFrameConsumed) { |
| EXPECT_CALL(stream_, AddBytesConsumed(2)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(2); |
| })); |
| |
| OnFrame(0, "abc"); |
| EXPECT_EQ(1u, NumBufferedBytes()); |
| EXPECT_EQ(2u, sequencer_->NumBytesConsumed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, NextxFrameNotConsumed) { |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| |
| OnFrame(0, "abc"); |
| EXPECT_EQ(3u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, FutureFrameNotProcessed) { |
| OnFrame(3, "abc"); |
| EXPECT_EQ(3u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, OutOfOrderFrameProcessed) { |
| // Buffer the first |
| OnFrame(6, "ghi"); |
| EXPECT_EQ(3u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| EXPECT_EQ(3u, sequencer_->NumBytesBuffered()); |
| // Buffer the second |
| OnFrame(3, "def"); |
| EXPECT_EQ(6u, NumBufferedBytes()); |
| EXPECT_EQ(0u, sequencer_->NumBytesConsumed()); |
| EXPECT_EQ(6u, sequencer_->NumBytesBuffered()); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(9)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(9); |
| })); |
| |
| // Now process all of them at once. |
| OnFrame(0, "abc"); |
| EXPECT_EQ(9u, sequencer_->NumBytesConsumed()); |
| EXPECT_EQ(0u, sequencer_->NumBytesBuffered()); |
| |
| EXPECT_EQ(0u, NumBufferedBytes()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, BasicHalfCloseOrdered) { |
| InSequence s; |
| |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(3); |
| })); |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| OnFinFrame(0, "abc"); |
| |
| EXPECT_EQ(3u, QuicStreamSequencerPeer::GetCloseOffset(sequencer_.get())); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, BasicHalfCloseUnorderedWithFlush) { |
| OnFinFrame(6, ""); |
| EXPECT_EQ(6u, QuicStreamSequencerPeer::GetCloseOffset(sequencer_.get())); |
| |
| OnFrame(3, "def"); |
| EXPECT_CALL(stream_, AddBytesConsumed(6)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(6); |
| })); |
| EXPECT_FALSE(sequencer_->IsClosed()); |
| OnFrame(0, "abc"); |
| EXPECT_TRUE(sequencer_->IsClosed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, BasicHalfUnordered) { |
| OnFinFrame(3, ""); |
| EXPECT_EQ(3u, QuicStreamSequencerPeer::GetCloseOffset(sequencer_.get())); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| EXPECT_CALL(stream_, OnDataAvailable()).WillOnce(testing::Invoke([this]() { |
| ConsumeData(3); |
| })); |
| EXPECT_FALSE(sequencer_->IsClosed()); |
| OnFrame(0, "abc"); |
| EXPECT_TRUE(sequencer_->IsClosed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, TerminateWithReadv) { |
| char buffer[3]; |
| |
| OnFinFrame(3, ""); |
| EXPECT_EQ(3u, QuicStreamSequencerPeer::GetCloseOffset(sequencer_.get())); |
| |
| EXPECT_FALSE(sequencer_->IsClosed()); |
| |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| OnFrame(0, "abc"); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| iovec iov = {&buffer[0], 3}; |
| int bytes_read = sequencer_->Readv(&iov, 1); |
| EXPECT_EQ(3, bytes_read); |
| EXPECT_TRUE(sequencer_->IsClosed()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, MultipleOffsets) { |
| OnFinFrame(3, ""); |
| EXPECT_EQ(3u, QuicStreamSequencerPeer::GetCloseOffset(sequencer_.get())); |
| |
| EXPECT_CALL(stream_, OnUnrecoverableError( |
| QUIC_STREAM_SEQUENCER_INVALID_STATE, |
| "Stream 1 received new final offset: 1, which is " |
| "different from close offset: 3")); |
| OnFinFrame(1, ""); |
| } |
| |
| class QuicSequencerRandomTest : public QuicStreamSequencerTest { |
| public: |
| using Frame = std::pair<int, std::string>; |
| using FrameList = std::vector<Frame>; |
| |
| void CreateFrames() { |
| int payload_size = ABSL_ARRAYSIZE(kPayload) - 1; |
| int remaining_payload = payload_size; |
| while (remaining_payload != 0) { |
| int size = std::min(OneToN(6), remaining_payload); |
| int index = payload_size - remaining_payload; |
| list_.push_back( |
| std::make_pair(index, std::string(kPayload + index, size))); |
| remaining_payload -= size; |
| } |
| } |
| |
| QuicSequencerRandomTest() { |
| uint64_t seed = QuicRandom::GetInstance()->RandUint64(); |
| QUIC_LOG(INFO) << "**** The current seed is " << seed << " ****"; |
| random_.set_seed(seed); |
| |
| CreateFrames(); |
| } |
| |
| int OneToN(int n) { return random_.RandUint64() % n + 1; } |
| |
| void ReadAvailableData() { |
| // Read all available data |
| char output[ABSL_ARRAYSIZE(kPayload) + 1]; |
| iovec iov; |
| iov.iov_base = output; |
| iov.iov_len = ABSL_ARRAYSIZE(output); |
| int bytes_read = sequencer_->Readv(&iov, 1); |
| EXPECT_NE(0, bytes_read); |
| output_.append(output, bytes_read); |
| } |
| |
| std::string output_; |
| // Data which peek at using GetReadableRegion if we back up. |
| std::string peeked_; |
| SimpleRandom random_; |
| FrameList list_; |
| }; |
| |
| // All frames are processed as soon as we have sequential data. |
| // Infinite buffering, so all frames are acked right away. |
| TEST_F(QuicSequencerRandomTest, RandomFramesNoDroppingNoBackup) { |
| EXPECT_CALL(stream_, OnDataAvailable()) |
| .Times(AnyNumber()) |
| .WillRepeatedly( |
| Invoke(this, &QuicSequencerRandomTest::ReadAvailableData)); |
| QuicByteCount total_bytes_consumed = 0; |
| EXPECT_CALL(stream_, AddBytesConsumed(_)) |
| .Times(AnyNumber()) |
| .WillRepeatedly( |
| testing::Invoke([&total_bytes_consumed](QuicByteCount bytes) { |
| total_bytes_consumed += bytes; |
| })); |
| |
| while (!list_.empty()) { |
| int index = OneToN(list_.size()) - 1; |
| QUIC_LOG(ERROR) << "Sending index " << index << " " << list_[index].second; |
| OnFrame(list_[index].first, list_[index].second.data()); |
| |
| list_.erase(list_.begin() + index); |
| } |
| |
| ASSERT_EQ(ABSL_ARRAYSIZE(kPayload) - 1, output_.size()); |
| EXPECT_EQ(kPayload, output_); |
| EXPECT_EQ(ABSL_ARRAYSIZE(kPayload) - 1, total_bytes_consumed); |
| } |
| |
| TEST_F(QuicSequencerRandomTest, RandomFramesNoDroppingBackup) { |
| char buffer[10]; |
| iovec iov[2]; |
| iov[0].iov_base = &buffer[0]; |
| iov[0].iov_len = 5; |
| iov[1].iov_base = &buffer[5]; |
| iov[1].iov_len = 5; |
| |
| EXPECT_CALL(stream_, OnDataAvailable()).Times(AnyNumber()); |
| QuicByteCount total_bytes_consumed = 0; |
| EXPECT_CALL(stream_, AddBytesConsumed(_)) |
| .Times(AnyNumber()) |
| .WillRepeatedly( |
| testing::Invoke([&total_bytes_consumed](QuicByteCount bytes) { |
| total_bytes_consumed += bytes; |
| })); |
| |
| while (output_.size() != ABSL_ARRAYSIZE(kPayload) - 1) { |
| if (!list_.empty() && OneToN(2) == 1) { // Send data |
| int index = OneToN(list_.size()) - 1; |
| OnFrame(list_[index].first, list_[index].second.data()); |
| list_.erase(list_.begin() + index); |
| } else { // Read data |
| bool has_bytes = sequencer_->HasBytesToRead(); |
| iovec peek_iov[20]; |
| int iovs_peeked = sequencer_->GetReadableRegions(peek_iov, 20); |
| if (has_bytes) { |
| ASSERT_LT(0, iovs_peeked); |
| ASSERT_TRUE(sequencer_->GetReadableRegion(peek_iov)); |
| } else { |
| ASSERT_EQ(0, iovs_peeked); |
| ASSERT_FALSE(sequencer_->GetReadableRegion(peek_iov)); |
| } |
| int total_bytes_to_peek = ABSL_ARRAYSIZE(buffer); |
| for (int i = 0; i < iovs_peeked; ++i) { |
| int bytes_to_peek = |
| std::min<int>(peek_iov[i].iov_len, total_bytes_to_peek); |
| peeked_.append(static_cast<char*>(peek_iov[i].iov_base), bytes_to_peek); |
| total_bytes_to_peek -= bytes_to_peek; |
| if (total_bytes_to_peek == 0) { |
| break; |
| } |
| } |
| int bytes_read = sequencer_->Readv(iov, 2); |
| output_.append(buffer, bytes_read); |
| ASSERT_EQ(output_.size(), peeked_.size()); |
| } |
| } |
| EXPECT_EQ(std::string(kPayload), output_); |
| EXPECT_EQ(std::string(kPayload), peeked_); |
| EXPECT_EQ(ABSL_ARRAYSIZE(kPayload) - 1, total_bytes_consumed); |
| } |
| |
| // Same as above, just using a different method for reading. |
| TEST_F(QuicStreamSequencerTest, MarkConsumed) { |
| InSequence s; |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| |
| OnFrame(0, "abc"); |
| OnFrame(3, "def"); |
| OnFrame(6, "ghi"); |
| |
| // abcdefghi buffered. |
| EXPECT_EQ(9u, sequencer_->NumBytesBuffered()); |
| |
| // Peek into the data. |
| std::vector<std::string> expected = {"abcdefghi"}; |
| ASSERT_TRUE(VerifyReadableRegions(expected)); |
| |
| // Consume 1 byte. |
| EXPECT_CALL(stream_, AddBytesConsumed(1)); |
| sequencer_->MarkConsumed(1); |
| // Verify data. |
| std::vector<std::string> expected2 = {"bcdefghi"}; |
| ASSERT_TRUE(VerifyReadableRegions(expected2)); |
| EXPECT_EQ(8u, sequencer_->NumBytesBuffered()); |
| |
| // Consume 2 bytes. |
| EXPECT_CALL(stream_, AddBytesConsumed(2)); |
| sequencer_->MarkConsumed(2); |
| // Verify data. |
| std::vector<std::string> expected3 = {"defghi"}; |
| ASSERT_TRUE(VerifyReadableRegions(expected3)); |
| EXPECT_EQ(6u, sequencer_->NumBytesBuffered()); |
| |
| // Consume 5 bytes. |
| EXPECT_CALL(stream_, AddBytesConsumed(5)); |
| sequencer_->MarkConsumed(5); |
| // Verify data. |
| std::vector<std::string> expected4{"i"}; |
| ASSERT_TRUE(VerifyReadableRegions(expected4)); |
| EXPECT_EQ(1u, sequencer_->NumBytesBuffered()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, MarkConsumedError) { |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| |
| OnFrame(0, "abc"); |
| OnFrame(9, "jklmnopqrstuvwxyz"); |
| |
| // Peek into the data. Only the first chunk should be readable because of the |
| // missing data. |
| std::vector<std::string> expected{"abc"}; |
| ASSERT_TRUE(VerifyReadableRegions(expected)); |
| |
| // Now, attempt to mark consumed more data than was readable and expect the |
| // stream to be closed. |
| EXPECT_QUIC_BUG( |
| { |
| EXPECT_CALL(stream_, ResetWithError(QuicResetStreamError::FromInternal( |
| QUIC_ERROR_PROCESSING_STREAM))); |
| sequencer_->MarkConsumed(4); |
| }, |
| "Invalid argument to MarkConsumed." |
| " expect to consume: 4, but not enough bytes available."); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, MarkConsumedWithMissingPacket) { |
| InSequence s; |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| |
| OnFrame(0, "abc"); |
| OnFrame(3, "def"); |
| // Missing packet: 6, ghi. |
| OnFrame(9, "jkl"); |
| |
| std::vector<std::string> expected = {"abcdef"}; |
| ASSERT_TRUE(VerifyReadableRegions(expected)); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(6)); |
| sequencer_->MarkConsumed(6); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, Move) { |
| InSequence s; |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| |
| OnFrame(0, "abc"); |
| OnFrame(3, "def"); |
| OnFrame(6, "ghi"); |
| |
| // abcdefghi buffered. |
| EXPECT_EQ(9u, sequencer_->NumBytesBuffered()); |
| |
| // Peek into the data. |
| std::vector<std::string> expected = {"abcdefghi"}; |
| ASSERT_TRUE(VerifyReadableRegions(expected)); |
| |
| QuicStreamSequencer sequencer2(std::move(*sequencer_)); |
| ASSERT_TRUE(VerifyReadableRegions(sequencer2, expected)); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, OverlappingFramesReceived) { |
| // The peer should never send us non-identical stream frames which contain |
| // overlapping byte ranges - if they do, we close the connection. |
| QuicStreamId id = 1; |
| |
| QuicStreamFrame frame1(id, false, 1, absl::string_view("hello")); |
| sequencer_->OnStreamFrame(frame1); |
| |
| QuicStreamFrame frame2(id, false, 2, absl::string_view("hello")); |
| EXPECT_CALL(stream_, OnUnrecoverableError(QUIC_OVERLAPPING_STREAM_DATA, _)) |
| .Times(0); |
| sequencer_->OnStreamFrame(frame2); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, DataAvailableOnOverlappingFrames) { |
| QuicStreamId id = 1; |
| const std::string data(1000, '.'); |
| |
| // Received [0, 1000). |
| QuicStreamFrame frame1(id, false, 0, data); |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| sequencer_->OnStreamFrame(frame1); |
| // Consume [0, 500). |
| EXPECT_CALL(stream_, AddBytesConsumed(500)); |
| QuicStreamSequencerTest::ConsumeData(500); |
| EXPECT_EQ(500u, sequencer_->NumBytesConsumed()); |
| EXPECT_EQ(500u, sequencer_->NumBytesBuffered()); |
| |
| // Received [500, 1500). |
| QuicStreamFrame frame2(id, false, 500, data); |
| // Do not call OnDataAvailable as there are readable bytes left in the buffer. |
| EXPECT_CALL(stream_, OnDataAvailable()).Times(0); |
| sequencer_->OnStreamFrame(frame2); |
| // Consume [1000, 1500). |
| EXPECT_CALL(stream_, AddBytesConsumed(1000)); |
| QuicStreamSequencerTest::ConsumeData(1000); |
| EXPECT_EQ(1500u, sequencer_->NumBytesConsumed()); |
| EXPECT_EQ(0u, sequencer_->NumBytesBuffered()); |
| |
| // Received [1498, 1503). |
| QuicStreamFrame frame3(id, false, 1498, absl::string_view("hello")); |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| sequencer_->OnStreamFrame(frame3); |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| QuicStreamSequencerTest::ConsumeData(3); |
| EXPECT_EQ(1503u, sequencer_->NumBytesConsumed()); |
| EXPECT_EQ(0u, sequencer_->NumBytesBuffered()); |
| |
| // Received [1000, 1005). |
| QuicStreamFrame frame4(id, false, 1000, absl::string_view("hello")); |
| EXPECT_CALL(stream_, OnDataAvailable()).Times(0); |
| sequencer_->OnStreamFrame(frame4); |
| EXPECT_EQ(1503u, sequencer_->NumBytesConsumed()); |
| EXPECT_EQ(0u, sequencer_->NumBytesBuffered()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, OnDataAvailableWhenReadableBytesIncrease) { |
| sequencer_->set_level_triggered(true); |
| QuicStreamId id = 1; |
| |
| // Received [0, 5). |
| QuicStreamFrame frame1(id, false, 0, "hello"); |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| sequencer_->OnStreamFrame(frame1); |
| EXPECT_EQ(5u, sequencer_->NumBytesBuffered()); |
| |
| // Without consuming the buffer bytes, continue receiving [5, 11). |
| QuicStreamFrame frame2(id, false, 5, " world"); |
| // OnDataAvailable should still be called because there are more data to read. |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| sequencer_->OnStreamFrame(frame2); |
| EXPECT_EQ(11u, sequencer_->NumBytesBuffered()); |
| |
| // Without consuming the buffer bytes, continue receiving [12, 13). |
| QuicStreamFrame frame3(id, false, 5, "a"); |
| // OnDataAvailable shouldn't be called becasue there are still only 11 bytes |
| // available. |
| EXPECT_CALL(stream_, OnDataAvailable()).Times(0); |
| sequencer_->OnStreamFrame(frame3); |
| EXPECT_EQ(11u, sequencer_->NumBytesBuffered()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, ReadSingleFrame) { |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| OnFrame(0u, "abc"); |
| std::string actual; |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| sequencer_->Read(&actual); |
| EXPECT_EQ("abc", actual); |
| EXPECT_EQ(0u, sequencer_->NumBytesBuffered()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, ReadMultipleFramesWithMissingFrame) { |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| OnFrame(0u, "abc"); |
| OnFrame(3u, "def"); |
| OnFrame(6u, "ghi"); |
| OnFrame(10u, "xyz"); // Byte 9 is missing. |
| std::string actual; |
| EXPECT_CALL(stream_, AddBytesConsumed(9)); |
| sequencer_->Read(&actual); |
| EXPECT_EQ("abcdefghi", actual); |
| EXPECT_EQ(3u, sequencer_->NumBytesBuffered()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, ReadAndAppendToString) { |
| EXPECT_CALL(stream_, OnDataAvailable()); |
| OnFrame(0u, "def"); |
| OnFrame(3u, "ghi"); |
| std::string actual = "abc"; |
| EXPECT_CALL(stream_, AddBytesConsumed(6)); |
| sequencer_->Read(&actual); |
| EXPECT_EQ("abcdefghi", actual); |
| EXPECT_EQ(0u, sequencer_->NumBytesBuffered()); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, StopReading) { |
| EXPECT_CALL(stream_, OnDataAvailable()).Times(0); |
| EXPECT_CALL(stream_, OnFinRead()); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(0)); |
| sequencer_->StopReading(); |
| |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| OnFrame(0u, "abc"); |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| OnFrame(3u, "def"); |
| EXPECT_CALL(stream_, AddBytesConsumed(3)); |
| OnFinFrame(6u, "ghi"); |
| } |
| |
| TEST_F(QuicStreamSequencerTest, StopReadingWithLevelTriggered) { |
| EXPECT_CALL(stream_, AddBytesConsumed(0)); |
| EXPECT_CALL(stream_, AddBytesConsumed(3)).Times(3); |
| EXPECT_CALL(stream_, OnDataAvailable()).Times(0); |
| EXPECT_CALL(stream_, OnFinRead()); |
| |
| sequencer_->set_level_triggered(true); |
| sequencer_->StopReading(); |
| |
| OnFrame(0u, "abc"); |
| OnFrame(3u, "def"); |
| OnFinFrame(6u, "ghi"); |
| } |
| |
| // Regression test for https://crbug.com/992486. |
| TEST_F(QuicStreamSequencerTest, CorruptFinFrames) { |
| EXPECT_CALL(stream_, OnUnrecoverableError( |
| QUIC_STREAM_SEQUENCER_INVALID_STATE, |
| "Stream 1 received new final offset: 1, which is " |
| "different from close offset: 2")); |
| |
| OnFinFrame(2u, ""); |
| OnFinFrame(0u, "a"); |
| EXPECT_FALSE(sequencer_->HasBytesToRead()); |
| } |
| |
| // Regression test for crbug.com/1015693 |
| TEST_F(QuicStreamSequencerTest, ReceiveFinLessThanHighestOffset) { |
| EXPECT_CALL(stream_, OnDataAvailable()).Times(1); |
| EXPECT_CALL(stream_, OnUnrecoverableError( |
| QUIC_STREAM_SEQUENCER_INVALID_STATE, |
| "Stream 1 received fin with offset: 0, which " |
| "reduces current highest offset: 3")); |
| OnFrame(0u, "abc"); |
| OnFinFrame(0u, ""); |
| } |
| |
| } // namespace |
| } // namespace test |
| } // namespace quic |