)]}'
{
  "commit": "8b6881bd2a9b4a70dfd7076b00df0062784dd951",
  "tree": "1cbe0d72872df24b4a8dff62e779e053ebb536a4",
  "parents": [
    "260ba76b9291497524c4794d2f68f5ce32abc2ff"
  ],
  "author": {
    "name": "bnc",
    "email": "bnc@google.com",
    "time": "Tue Jul 21 10:44:43 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Jul 21 10:45:22 2020 -0700"
  },
  "message": "Update goaway frame field name and type. not protected.\n\nMotivation for type change: remote endpoints might send GOAWAY frames with ID\nlarger than what could be represented on QuicStreamId (uint32_t).  It is\nimportant that a value like 2^32+8 is not treated as 8 but as the largest\npossible QuicStreamId.  The ideal place to handle this is\nQuicSpdySession::OnHttp3GoAway(), therefore this CL plumbs 64 bits there from\nHttpDecoder::FinishParsing().  For the time being this only means moving the\nexplicit cast, so there is no behavior change.\n\nThere is no need to change SendHttp3GoAway() to handle 64 bit values, because\nQuicStreamId is only 32 bits internally, so 2^32-4 is sufficient to send when\ndoing graceful shutdown (which is not yet implemented).\n\nMotivation for name change: https://github.com/quicwg/base-drafts/pull/3129\nintroduces GOAWAY frames sent from client to server, in which case the payload\ncarries a push ID, not a stream ID.\n\nPiperOrigin-RevId: 322393259\nChange-Id: I472ec669259d675705790ee12c9404ca3d54195c\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d6c97ee7addd23edc4d5adb9a0e7728cd6580002",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_decoder.cc",
      "new_id": "3e067036e8d2c58afa5d6ea42ef82d90f8d95ae4",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_decoder.cc"
    },
    {
      "type": "modify",
      "old_id": "86a1b6932ec6ed195b3cce5f2aba43b4ce15b03f",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_decoder_test.cc",
      "new_id": "01f0a5fbfa9eb4116f82ae3b14a30893a62793e7",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_decoder_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a51abbebdc2767ec84eb737e421d1c1c46e0ad12",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_encoder.cc",
      "new_id": "770770561f773621d3ede73436c029dbf9f13d6c",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_encoder.cc"
    },
    {
      "type": "modify",
      "old_id": "aad20e5d95e60a06a70ddf27e4adf5861edca5f3",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_encoder_test.cc",
      "new_id": "f6c04449a39f4b37df04fb98f07ee91ac4ba5875",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_encoder_test.cc"
    },
    {
      "type": "modify",
      "old_id": "242f72b477968d8e0c570eca6bc18cce7bce9b0b",
      "old_mode": 33188,
      "old_path": "quic/core/http/http_frames.h",
      "new_id": "159b250088edb9f25f9e818017a4c0c0c0f0d250",
      "new_mode": 33188,
      "new_path": "quic/core/http/http_frames.h"
    },
    {
      "type": "modify",
      "old_id": "27de70d3fa4cb0e71a10a3b57688dd30ec830ec7",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_receive_control_stream.cc",
      "new_id": "e0e51a7dadc32102b26135a73647212508d5d7fb",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_receive_control_stream.cc"
    },
    {
      "type": "modify",
      "old_id": "b7517b50ec01f1189ae56931fadac84761118297",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_receive_control_stream_test.cc",
      "new_id": "91e09f2c4aec2505caf407713d220973db0cac75",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_receive_control_stream_test.cc"
    },
    {
      "type": "modify",
      "old_id": "59574a146b9432eee447956a510e63e3ef9d58cc",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_send_control_stream.cc",
      "new_id": "7be8ee4d46fc99512ebbf7f7353e3f59f0a3d8ce",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_send_control_stream.cc"
    },
    {
      "type": "modify",
      "old_id": "c14254f4cb757b6e752103231413f4e1f896f3e7",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_send_control_stream.h",
      "new_id": "6240310c80a1e7582a7004eb8980a8aeac96c9cd",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_send_control_stream.h"
    },
    {
      "type": "modify",
      "old_id": "850858ea0728a93ad1828bae0c9abc2a5b81686a",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_session.cc",
      "new_id": "b0bf7e91ae0a2eaedd4efa15f1ccd73661273a00",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_session.cc"
    },
    {
      "type": "modify",
      "old_id": "e437d980f2a378d31b7fc94c3f9ee0399f7b506f",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_session.h",
      "new_id": "9342da2f082a645d965955e4bf30e83b83e048e7",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_session.h"
    },
    {
      "type": "modify",
      "old_id": "a8e5230df8d67398e609555839937ec9fc5e0cff",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_stream_test.cc",
      "new_id": "64ef39aa005542505de23b694d4639336f94dfd7",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_stream_test.cc"
    }
  ]
}
