)]}'
{
  "commit": "85f18900f41d65dfe417a549703bd4b46289bed3",
  "tree": "454acaede75a2caada4830ba369bef06535ad341",
  "parents": [
    "0220865bffc15469c7e76ec9a1c573bcf395afab"
  ],
  "author": {
    "name": "fkastenholz",
    "email": "fkastenholz@google.com",
    "time": "Tue May 28 12:47:00 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed May 29 13:09:21 2019 -0700"
  },
  "message": "QuicConnection methods call CloseConnection rather than\nTearDownLocalConnectionState\n\nSome of the QuicConnection methods call TearDownLocalConnectionState\nrather than CloseConnection. This changes then all to call CloseConnection,\nspecifying ConnectionCloseBehavior::SILENT_CLOSE.\n\nSome tests modified to expect calls to CloseConnection (preventing test failure due to unexpected calls).  Before this CL the connection closing happened via internal calls directly to TearDownLocalConnectionState; now these calls go through CloseConnection and trigger the expect.\n\nThis is done in preparation for landing another CL adding IETF QUIC Connection Close functionality.\n\nQuicConnection::OnUnrecoverableError (which is an override of QuicPacketCreator::OnUnrecoverableError) called TearDownLocalConnectionState. It had to be modified to call CloseConnection.  OnUnrecoverableError has a ConnectionCloseSource parameter, which CloseConnection does not take.  Thus the parameter was removed from OnUnrecoverableError.  This is OK since all of the calls to OnUnrecoverableError specified FROM_SELF as the source. CloseConnection uses FROM_SELF as the source (unless the error code is a stateless reject or public reset).\n\ngfe-relnote: No flag protection as it is only moving existing functionality around.\nPiperOrigin-RevId: 250341745\nChange-Id: Iafe499eda682f3db678d0eddbf7e2e3e4367cebd\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d40ad736ed8dee66fe1a42dfe824779736a93f0a",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_session_test.cc",
      "new_id": "942688a62e7143bdcd46bc6e85e30754d85809b2",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_session_test.cc"
    },
    {
      "type": "modify",
      "old_id": "db717b02d68875b617df76bd41a76fe52e152393",
      "old_mode": 33188,
      "old_path": "quic/core/quic_connection.cc",
      "new_id": "6afc62da3eb36e9856710fb6a05c5de7d9a461c1",
      "new_mode": 33188,
      "new_path": "quic/core/quic_connection.cc"
    },
    {
      "type": "modify",
      "old_id": "3126e0b3a4756cb4e1e39b5a2dd28f083d907073",
      "old_mode": 33188,
      "old_path": "quic/core/quic_connection.h",
      "new_id": "9392f26e949119fba98bd7fe4981e73101c88721",
      "new_mode": 33188,
      "new_path": "quic/core/quic_connection.h"
    },
    {
      "type": "modify",
      "old_id": "0833a275355808ad6ebc15d9127c9f3e87b6aaed",
      "old_mode": 33188,
      "old_path": "quic/core/quic_dispatcher.cc",
      "new_id": "609c6b6d406944c26dff35ea80c9445086735520",
      "new_mode": 33188,
      "new_path": "quic/core/quic_dispatcher.cc"
    },
    {
      "type": "modify",
      "old_id": "9f9a68f4b9a225efec76c6cbbb1d1f6c93ad6f84",
      "old_mode": 33188,
      "old_path": "quic/core/quic_packet_creator.cc",
      "new_id": "5a53ffd9d3ac7e0e6790f49e922575cc6f709b80",
      "new_mode": 33188,
      "new_path": "quic/core/quic_packet_creator.cc"
    },
    {
      "type": "modify",
      "old_id": "06acfbe5e6c945062180d653c57da0f93a31b367",
      "old_mode": 33188,
      "old_path": "quic/core/quic_packet_creator.h",
      "new_id": "c9e31ac95359d1f02d4b63ddaead736a774fb005",
      "new_mode": 33188,
      "new_path": "quic/core/quic_packet_creator.h"
    },
    {
      "type": "modify",
      "old_id": "655d587015cdf8cd2f238c840e61463369cd7914",
      "old_mode": 33188,
      "old_path": "quic/core/quic_packet_creator_test.cc",
      "new_id": "bf695637322fa521e82d36d88ecc04858e32ff81",
      "new_mode": 33188,
      "new_path": "quic/core/quic_packet_creator_test.cc"
    },
    {
      "type": "modify",
      "old_id": "6f578f5f36dc66a077f6265a25251f51501caf63",
      "old_mode": 33188,
      "old_path": "quic/core/quic_packet_generator.cc",
      "new_id": "d57aad41f472bb64d4301c707f4415e8ea1c558e",
      "new_mode": 33188,
      "new_path": "quic/core/quic_packet_generator.cc"
    },
    {
      "type": "modify",
      "old_id": "e1899ffeb7d6570fb5edaaacffffd6a54c5886a6",
      "old_mode": 33188,
      "old_path": "quic/core/quic_packet_generator_test.cc",
      "new_id": "7212e22f76ac8d2199d7e7908ec38215b6d2a48d",
      "new_mode": 33188,
      "new_path": "quic/core/quic_packet_generator_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a889804599fae8d866699860867861e467dcc6e6",
      "old_mode": 33188,
      "old_path": "quic/test_tools/quic_test_utils.h",
      "new_id": "4f6a30a17c0289f1336f96d6de42e532333ad2a1",
      "new_mode": 33188,
      "new_path": "quic/test_tools/quic_test_utils.h"
    },
    {
      "type": "modify",
      "old_id": "e5298eb9c8387984bdc48f45a8f8b8edb3ecc751",
      "old_mode": 33188,
      "old_path": "quic/test_tools/simple_session_notifier_test.cc",
      "new_id": "d2aad9f087e3f92ccc36bb70ff27f7159c7795ff",
      "new_mode": 33188,
      "new_path": "quic/test_tools/simple_session_notifier_test.cc"
    }
  ]
}