)]}'
{
  "commit": "77e77b840f1a5241a8d3338faa9706d23053ebf7",
  "tree": "8328f00547bff968398675f0f77c53ecda5c4b8a",
  "parents": [
    "cbd4ea311cc559b798db085421aa1a772d8d7db6"
  ],
  "author": {
    "name": "bnc",
    "email": "bnc@google.com",
    "time": "Sun Apr 05 10:36:49 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Sun Apr 05 10:37:35 2020 -0700"
  },
  "message": "gfe-relnote:  Refactor QuicConnectionCloseFrame.  Not protected.\n\nQuicConnectionCloseFrame::quic_error_code should not be accessed when using IETF\nQUIC, however, as it is a public member, this is not enforced.  When read, it\nreturns the on-the-wire error code (transport or application) cast into a\nQuicErrorCode.  This is bad.\n\nSince public unions cannot enforce restrictions on access, I propose to remove\nthe union for clarity.  The price paid is type: wire_error_code will now be\nuint64_t even for Google QUIC error codes which could be QuicErrorCode, and for\nIETF QUIC transport errors, which could be QuicIetfTransportErrorCodes.\n\nAlso rename extracted_error_code to quic_error_code for clarity, because for\nsent frames, it is not extracted.\n\nThis refactor is necessary for modifying QuicErrorCodeToTransportErrorCode() to\nreturn IETF wire error codes.\n\nWhen using Google QUIC, old fields |quic_error_code| and |extracted_error_code|\nand new fields |wire_error_code| and |quic_error_code| should always have the\nsame value, therefore this refactor should not introduce any functional change.\n\nPiperOrigin-RevId: 304902883\nChange-Id: I586a92609fb8a6186310f6585c8d29ee1d60af4f\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "35aedf4a2924edd8b504e60027ba94593087e67c",
      "old_mode": 33188,
      "old_path": "quic/core/frames/quic_connection_close_frame.cc",
      "new_id": "6e5115bc395baabc8fbd9138637b317cf77a2fb5",
      "new_mode": 33188,
      "new_path": "quic/core/frames/quic_connection_close_frame.cc"
    },
    {
      "type": "modify",
      "old_id": "4ee41b97fd9214da8eac5626978343fbd4656360",
      "old_mode": 33188,
      "old_path": "quic/core/frames/quic_connection_close_frame.h",
      "new_id": "ce41b030edf8c1b6ef6c58c55243f5f5acf00f9f",
      "new_mode": 33188,
      "new_path": "quic/core/frames/quic_connection_close_frame.h"
    },
    {
      "type": "modify",
      "old_id": "7450adb5d2c7af65951298edcdcb09b797292ee3",
      "old_mode": 33188,
      "old_path": "quic/core/frames/quic_frames_test.cc",
      "new_id": "22322ed8ee2051ad17321beffdfbf63cd281ff21",
      "new_mode": 33188,
      "new_path": "quic/core/frames/quic_frames_test.cc"
    },
    {
      "type": "modify",
      "old_id": "f83dbdd8950435a1582dbef62189c05a5e99127d",
      "old_mode": 33188,
      "old_path": "quic/core/quic_connection.cc",
      "new_id": "99e88c30516bade6c4e529dc318f2b9c218bd157",
      "new_mode": 33188,
      "new_path": "quic/core/quic_connection.cc"
    },
    {
      "type": "modify",
      "old_id": "e5faa3586da95be590ad642a265bf36726831978",
      "old_mode": 33188,
      "old_path": "quic/core/quic_connection_test.cc",
      "new_id": "ded114b2d8c426bbb37940a4c01908b76431419b",
      "new_mode": 33188,
      "new_path": "quic/core/quic_connection_test.cc"
    },
    {
      "type": "modify",
      "old_id": "f90019176aa0d5c79eba1d7dc9acf11632899e43",
      "old_mode": 33188,
      "old_path": "quic/core/quic_framer.cc",
      "new_id": "58130109e6fd0d3e4560c21e094f5a538f1b3b2c",
      "new_mode": 33188,
      "new_path": "quic/core/quic_framer.cc"
    },
    {
      "type": "modify",
      "old_id": "746e6a1dacc0d077ce1ac9eef7bf171e46e7feaf",
      "old_mode": 33188,
      "old_path": "quic/core/quic_framer.h",
      "new_id": "f0c694a761dc3893d6be36c131433cf52ffe9c0d",
      "new_mode": 33188,
      "new_path": "quic/core/quic_framer.h"
    },
    {
      "type": "modify",
      "old_id": "813d4f6c27069cb9bfd4601c8a2e4fc48cd8799e",
      "old_mode": 33188,
      "old_path": "quic/core/quic_framer_test.cc",
      "new_id": "d274c6c0de60316131dcd1ec3156f8d55dd883ae",
      "new_mode": 33188,
      "new_path": "quic/core/quic_framer_test.cc"
    },
    {
      "type": "modify",
      "old_id": "bd29b8ed1a5a2e7754b94389e6138708b120a65a",
      "old_mode": 33188,
      "old_path": "quic/core/quic_session.cc",
      "new_id": "62a1ae307719188beed04ae0c0f777e5eec25378",
      "new_mode": 33188,
      "new_path": "quic/core/quic_session.cc"
    },
    {
      "type": "modify",
      "old_id": "6e073237ea9637153c7ff2f30e081a2db487ada3",
      "old_mode": 33188,
      "old_path": "quic/core/quic_session.h",
      "new_id": "ee8e51207b3499a78d531cae07b8a2f4629786a8",
      "new_mode": 33188,
      "new_path": "quic/core/quic_session.h"
    },
    {
      "type": "modify",
      "old_id": "9745955799fc06e5113e22a28067a28a38af8821",
      "old_mode": 33188,
      "old_path": "quic/tools/quic_client_interop_test_bin.cc",
      "new_id": "25e9c1e5749c05df92a31737dad42d80509d3f6e",
      "new_mode": 33188,
      "new_path": "quic/tools/quic_client_interop_test_bin.cc"
    }
  ]
}