)]}'
{
  "commit": "6ebe83b7608c717c4568d8cdf775f51a05d69c77",
  "tree": "bfba35a4a132df62258475a5b2c3fa1a1d455b9e",
  "parents": [
    "f245d294d1705f5bd4b3df83296dbbd9feff0449"
  ],
  "author": {
    "name": "nharper",
    "email": "nharper@google.com",
    "time": "Thu Jun 13 17:43:52 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri Jun 14 09:41:02 2019 -0700"
  },
  "message": "Refactor TlsHandshaker classes\n\nQuicCryptoClientConfig and QuicCryptoServerConfig each own an SSL_CTX,\nwhich is currently created by TlsHandshaker. Those crypto config classes\ncan\u0027t take a dependency on TlsHandshaker (because TlsHandshaker depends on\nclasses have a dependency in the other direction), resulting in the SSL_CTX\nbeing passed into the crypto config constructors. The SSL_CTX shouldn\u0027t be\nexposed like this, as it\u0027s essentially an implementation detail of the\ncrypto handshake.\n\nThis CL splits TlsHandshaker in two. TlsConnection (and its subclasses) are\nin quic/core/crypto, and handle the callbacks from BoringSSL. In turn, it\npasses the implementation of those callbacks to a delegate. TlsHandshaker\nimplements this delegate and owns the TlsConnection.\n\ngfe-relnote: refactor TLS handshake classes in QUIC; not flag protected\nPiperOrigin-RevId: 253140899\nChange-Id: Ie907a7f61798c29a385be15ea0f53403b86508ab\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8663832b9be414f4a35948def182b0172f560328",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/crypto_server_test.cc",
      "new_id": "92f774cf06782a8d6a5d767a4b36317bea319d6f",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/crypto_server_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c967b1764b6be1025284473105e70b6abcb96420",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_crypto_client_config.cc",
      "new_id": "14f134702c5f36c9806399f58f35964bbf15d38d",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_crypto_client_config.cc"
    },
    {
      "type": "modify",
      "old_id": "2918a23bb1388f37209f016321fe2d0fca4efd8b",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_crypto_client_config.h",
      "new_id": "2d951036a7742fdc1d8d08c41d81209e68221c44",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_crypto_client_config.h"
    },
    {
      "type": "modify",
      "old_id": "563c7f1cc8036eb8a6908762ac92d6f28eaf3d64",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_crypto_client_config_test.cc",
      "new_id": "7b473de76a0b7bfa2079082e185a414d349a7789",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_crypto_client_config_test.cc"
    },
    {
      "type": "modify",
      "old_id": "9d70641665465d767c1fe20b47598c2f9b5cf666",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_crypto_server_config.cc",
      "new_id": "24d0500b127b79ddcd65586527dc89be9c80909d",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_crypto_server_config.cc"
    },
    {
      "type": "modify",
      "old_id": "503b377f33255e06896f4230f7acb5c1d9bc5dd8",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_crypto_server_config.h",
      "new_id": "85edc0e7ff48f28a8275c32b7d814d054a383958",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_crypto_server_config.h"
    },
    {
      "type": "modify",
      "old_id": "b3f8f77b51dbd1f582e7eeaa16a46948c514fc95",
      "old_mode": 33188,
      "old_path": "quic/core/crypto/quic_crypto_server_config_test.cc",
      "new_id": "90da3cdf099ad6b2475400044ababa28de6441f4",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/quic_crypto_server_config_test.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "f28af660e904027a209dbc1041d2c0b12304d301",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/tls_client_connection.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c7413894bb2e3d83fc5a2c0c0373b681ceb67f3a",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/tls_client_connection.h"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "d28db2292e48cfddb1ceb83dfb152e893aca0343",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/tls_connection.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "15c2b6764956bfff0d6ea05ec8392efbff85b0cf",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/tls_connection.h"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "a3a18150c17cc69f90b89011a4464aeb08ef6dfb",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/tls_server_connection.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "a5d087ca03a5ca1f9c2049476b03cad215c26953",
      "new_mode": 33188,
      "new_path": "quic/core/crypto/tls_server_connection.h"
    },
    {
      "type": "modify",
      "old_id": "104c049e87e61d4201deea9e5f2d4df50edb6276",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_client_promised_info_test.cc",
      "new_id": "24d4821364e093c259f6d4349b48af92f56d0d2b",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_client_promised_info_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c12a3285af894abdf4bee9897f4c8aa881e3994f",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_client_push_promise_index_test.cc",
      "new_id": "401ea86c29ca66349506505af02058c246491b33",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_client_push_promise_index_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c3fac3edbfca093fb3e334414dfd0f076277c172",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_server_session_base_test.cc",
      "new_id": "a0ce23e499a21407e6114f4c0c89118b34fcbb2a",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_server_session_base_test.cc"
    },
    {
      "type": "modify",
      "old_id": "847de2b9db3fc9870bc4c97e186b1b63a47df803",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_client_session_test.cc",
      "new_id": "9aff364e139e374211fcae4f9edd0e9def35d856",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_client_session_test.cc"
    },
    {
      "type": "modify",
      "old_id": "6d63ad3cee0114da9d67026daf320d5dee572058",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_client_stream_test.cc",
      "new_id": "4354a2f9871b4d6c204482b0e65b7a3929809403",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_client_stream_test.cc"
    },
    {
      "type": "modify",
      "old_id": "92cfab1f3e065b3b38d26632bdb88bb47e28cd8e",
      "old_mode": 33188,
      "old_path": "quic/core/quic_crypto_client_handshaker_test.cc",
      "new_id": "d9e33b76d3edfd61fbce21b5680ff9abcc736bd4",
      "new_mode": 33188,
      "new_path": "quic/core/quic_crypto_client_handshaker_test.cc"
    },
    {
      "type": "modify",
      "old_id": "e09546d93ca9fc0ac1f4d8e2dd69cd602bf13319",
      "old_mode": 33188,
      "old_path": "quic/core/quic_crypto_client_stream_test.cc",
      "new_id": "e0229bca05045958b9f7d40dedb98e4f391760fe",
      "new_mode": 33188,
      "new_path": "quic/core/quic_crypto_client_stream_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5105a27b53c7a8f33ba380f4d53dafbeace97116",
      "old_mode": 33188,
      "old_path": "quic/core/quic_crypto_server_stream_test.cc",
      "new_id": "238162c96efeb064be2d9a82a31cf25254d1c6c6",
      "new_mode": 33188,
      "new_path": "quic/core/quic_crypto_server_stream_test.cc"
    },
    {
      "type": "modify",
      "old_id": "87742dbeb7277609f5e4157b2517bac3d397aa51",
      "old_mode": 33188,
      "old_path": "quic/core/quic_dispatcher_test.cc",
      "new_id": "9817ea4788f5b924eea285de56249671e11574c6",
      "new_mode": 33188,
      "new_path": "quic/core/quic_dispatcher_test.cc"
    },
    {
      "type": "modify",
      "old_id": "db1f6b480d686da8868e2d70fa59c935655c82d7",
      "old_mode": 33188,
      "old_path": "quic/core/tls_client_handshaker.cc",
      "new_id": "d90b6f5f429956e20f9eee5a5d3aa40d5947f0cf",
      "new_mode": 33188,
      "new_path": "quic/core/tls_client_handshaker.cc"
    },
    {
      "type": "modify",
      "old_id": "3647e10f084ea8a7f2f0459ab53193a3899e6264",
      "old_mode": 33188,
      "old_path": "quic/core/tls_client_handshaker.h",
      "new_id": "d3e1e0cdcfe17612ddea40e9cf2decd357c1e635",
      "new_mode": 33188,
      "new_path": "quic/core/tls_client_handshaker.h"
    },
    {
      "type": "modify",
      "old_id": "aeadfd4b218c59ed0938b94da9270ce7d6084992",
      "old_mode": 33188,
      "old_path": "quic/core/tls_handshaker.cc",
      "new_id": "3c82a49b6c2271fccadd30fdc235275fa7483722",
      "new_mode": 33188,
      "new_path": "quic/core/tls_handshaker.cc"
    },
    {
      "type": "modify",
      "old_id": "96589237c925b30b4314dc0ef9be0223a3ac91a3",
      "old_mode": 33188,
      "old_path": "quic/core/tls_handshaker.h",
      "new_id": "b4f16e8a3d171135199cf60949fb96c2182cb403",
      "new_mode": 33188,
      "new_path": "quic/core/tls_handshaker.h"
    },
    {
      "type": "modify",
      "old_id": "e710d7b166bc6a85b71751cb18a9d5601e546373",
      "old_mode": 33188,
      "old_path": "quic/core/tls_handshaker_test.cc",
      "new_id": "cc22c59f85138744345a86903097c163cfe2d3ae",
      "new_mode": 33188,
      "new_path": "quic/core/tls_handshaker_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ca56e4dd3d2c4a465eeb846de3d949265d1d7186",
      "old_mode": 33188,
      "old_path": "quic/core/tls_server_handshaker.cc",
      "new_id": "fdda21f705f516310e0ecc7db72f18a2a013c3ec",
      "new_mode": 33188,
      "new_path": "quic/core/tls_server_handshaker.cc"
    },
    {
      "type": "modify",
      "old_id": "e27d896731476d8067d03de56f70ef210b767a32",
      "old_mode": 33188,
      "old_path": "quic/core/tls_server_handshaker.h",
      "new_id": "479342e3a9ec4574ffdceb725dee74e26ae28cdb",
      "new_mode": 33188,
      "new_path": "quic/core/tls_server_handshaker.h"
    },
    {
      "type": "modify",
      "old_id": "354856a718b7018a41992beab3c17a78e706c302",
      "old_mode": 33188,
      "old_path": "quic/test_tools/crypto_test_utils.cc",
      "new_id": "0b672873b9716d4a9f818b0b20093e3671371808",
      "new_mode": 33188,
      "new_path": "quic/test_tools/crypto_test_utils.cc"
    },
    {
      "type": "modify",
      "old_id": "069413b3a86d6ba01f0c528de52b01fae26bcbc6",
      "old_mode": 33188,
      "old_path": "quic/test_tools/crypto_test_utils_test.cc",
      "new_id": "e7f9679058d4f72994281daa88a9c49b7efb5593",
      "new_mode": 33188,
      "new_path": "quic/test_tools/crypto_test_utils_test.cc"
    },
    {
      "type": "modify",
      "old_id": "9cecffe3fa4cd35a968be90e634e4b9bcabc4d22",
      "old_mode": 33188,
      "old_path": "quic/tools/quic_client_base.cc",
      "new_id": "b03f7cc342d709bb91b70ff78ccaa28db52d2a11",
      "new_mode": 33188,
      "new_path": "quic/tools/quic_client_base.cc"
    },
    {
      "type": "modify",
      "old_id": "3696b7cd06bc66619075eb4952f24193266118a1",
      "old_mode": 33188,
      "old_path": "quic/tools/quic_server.cc",
      "new_id": "8820040e56559b271e07b1f12b7ccc59acd1b23b",
      "new_mode": 33188,
      "new_path": "quic/tools/quic_server.cc"
    },
    {
      "type": "modify",
      "old_id": "bb007cbb49ae9e244b05128dcd55e04c5c66fbad",
      "old_mode": 33188,
      "old_path": "quic/tools/quic_server_test.cc",
      "new_id": "b1a88a6f13fa4c882317b08e4e5ebce54eaef0fb",
      "new_mode": 33188,
      "new_path": "quic/tools/quic_server_test.cc"
    },
    {
      "type": "modify",
      "old_id": "9071e052e0938cdb840d29ee5f24d1a5aa2db71f",
      "old_mode": 33188,
      "old_path": "quic/tools/quic_simple_server_session_test.cc",
      "new_id": "457f3faff2114f4012c44c69519b9e3dd8ce4665",
      "new_mode": 33188,
      "new_path": "quic/tools/quic_simple_server_session_test.cc"
    },
    {
      "type": "modify",
      "old_id": "fcceb3361efe1a09d58e004b974be8186e8769e1",
      "old_mode": 33188,
      "old_path": "quic/tools/quic_simple_server_stream_test.cc",
      "new_id": "9ce38fb2b34335d00a9834203866b30539bc14e5",
      "new_mode": 33188,
      "new_path": "quic/tools/quic_simple_server_stream_test.cc"
    }
  ]
}