)]}'
{
  "commit": "696ee606fd34c32d5c913e936edc3224174b2d3f",
  "tree": "dbb57af5ff5182ff1e69275a193c3a96e15a66f3",
  "parents": [
    "43a1c0f10f2855c3cd142f500e8d19ac6d6f5a8c"
  ],
  "author": {
    "name": "dschinazi",
    "email": "dschinazi@google.com",
    "time": "Thu Apr 25 16:05:35 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri Apr 26 08:58:37 2019 -0700"
  },
  "message": "Make QUIC EXPECT and ASSERT test macros reject comparison of unsigned integers\n\nThis CL overrides the CHECK/DCHECK/EXPECT/ASSERT macros. Unfortunately these macros allow comparison of integers of different signs, which allows us to write EXPECT_EQ(a, b) when a and b have different signs. However, the equivalent macros in Chromium do not allow this mismatch, and this has caused as number of quiche merge issues. Therefore, to avoid those, we add a non-executed comparison to the macros which ensures that compilation fails if there is a comparison of different signs. An example of the fix previously required for quiche merge can be found in cl/244853842.\n\ngfe-relnote: n/a, changes only impact compile-time for debug builds and tests\nPiperOrigin-RevId: 245325129\nChange-Id: I1e4d0bb424754c62e62a72378789ae6902eb9af5\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f03aa6d80fe41eca5bceedff76d51dfed6f1816a",
      "old_mode": 33188,
      "old_path": "quic/core/quic_packet_reader.cc",
      "new_id": "d2dfd2245fb38de32741a00c135560b8d4c6c51f",
      "new_mode": 33188,
      "new_path": "quic/core/quic_packet_reader.cc"
    },
    {
      "type": "modify",
      "old_id": "d1b442ed888ac3f14d3be52be586bb466750d8e5",
      "old_mode": 33188,
      "old_path": "quic/core/quic_stream_test.cc",
      "new_id": "b9d97a198d8549f616f7bae27cf2f4697bc6b41b",
      "new_mode": 33188,
      "new_path": "quic/core/quic_stream_test.cc"
    }
  ]
}