)]}'
{
  "commit": "5b182b9b0cd13a8cfa91344f7d6e9a2a02f3a998",
  "tree": "75d22eebc6ddb144c551099dbb0a41434d992d78",
  "parents": [
    "4dc4ba3939363a5f8b16aba53201d935db04f21a"
  ],
  "author": {
    "name": "bnc",
    "email": "bnc@google.com",
    "time": "Tue Jul 30 11:00:15 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Jul 30 11:03:46 2019 -0700"
  },
  "message": "Refactor incoming SETTINGS logic to QuicSpdySession::OnSetting().\n\nMove Google QUIC logic from QuicSpdySession::SpdyFramerVisitor::OnSettings(),\nand IETF QUIC logic from QuicReceiveControlStream::OnSettingsFrame() together\ninto new method QuicSpdySession::OnSetting().\n\nConsistently use spdy:: settings identifiers for former and quic:: settings\nidentifiers for latter.  (This reverts part of what I did at cr/260526616.  My\nconfusion about the two different kind of settings is in great part what\nmotivates this CL so that all SETTINGS logic is in one place).\n\nInline a number of QuicSpdySession methods now that they are not called from\noutside the class:\n  * UpdateHeaderEncoderTableSize(),\n  * UpdateEnableServerPush(),\n  * set_server_push_enabled(),\n  * set_max_outbound_header_list_size().\n\nThis change does not modify behavior.  Note that in case of Google QUIC, settings\nidentifiers (uint16_t) and values (uint32_t) are cast to uint64_t then back to\ntheir respective type, which is a no-op.\n\ngfe-relnote: n/a, no behavioral change.\nPiperOrigin-RevId: 260752115\nChange-Id: I6b24c98542375e55d907027127ffa1149eaffea6\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4408e59644b943c6cd20521d65b3cc20bf8bd3f9",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_receive_control_stream.cc",
      "new_id": "8b26afc059cf4e452981e416f6f856ecc8ade532",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_receive_control_stream.cc"
    },
    {
      "type": "modify",
      "old_id": "0e909edabfd3ccd747deaeb85c15623413798bfc",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_session.cc",
      "new_id": "3c3f8e04eb37cef33c0e80343a3a8e8b017aaf22",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_session.cc"
    },
    {
      "type": "modify",
      "old_id": "8d8bbda04fa4ac8086b167da159a8bb0a4c29eed",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_session.h",
      "new_id": "1fa0be70a0b2de490d95d4c21af25e19bd4382ee",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_session.h"
    }
  ]
}