tree e631d5e4de43c2e73419c69bb991bd05fdc790b4
parent c31628a3b8f02701bc4ac66adf86e4ec21ffa119
author bnc <bnc@google.com> 1580996997 -0800
committer Copybara-Service <copybara-worker@google.com> 1580997037 -0800

Do not call HpackWholeEntryBuffer::error_detected() in HpackDecoder::error_detected().

There is no point in calling HpackWholeEntryBuffer::error_detected() in
HpackDecoder::error_detected(), because HpackWholeEntryBuffer is constructed
with HpackDecoder::decoder_state_ as its listener, so when
HpackWholeEntryBuffer::error_detected_ is set in
HpackWholeEntryBuffer::ReportError(), HpackDecoder::decoder_state_ is also
notified via OnHpackDecodeError(), which calls HpackDecoderState::ReportError(),
setting HpackDecoderState::error_detected_ which HpackDecoder::error_detected()
queries anyway.

This simplification is in preparation for introducing an error code enum to
plumb error reasons into QuicSpdySession.

gfe-relnote: Do not call HpackWholeEntryBuffer::error_detected() in HpackDecoder::error_detected().  Protected by gfe_reloadable_flag_http2_skip_querying_entry_buffer_error.
PiperOrigin-RevId: 293574711
Change-Id: I14248de25e164cc97787082553b8226f6a8921dd