tree 718fd9f75c511dbb9837ec3f53a3cb1e9000af61
parent 448f04c7bb84a404a099d27dac192317ab221f85
author bnc <bnc@google.com> 1579806294 -0800
committer Copybara-Service <copybara-worker@google.com> 1579806334 -0800

gfe-relnote: Fix invalid downcast.

QuicTransportServerSessionTest fails on UBSAN builds in Chromium, see
https://crrev.com/c/2015242.

QuicTransportServerSession initializes |crypto_stream_| in the constructor using
CreateCryptoServerStream(), which since cr/290819354 might return a
TlsServerHandshaker, which is a derived class of QuicCryptoServerStreamBase but
not of QuicCryptoServerStream.  Hence the downcast fails in
QuicTransportServerSessionTest constructor.  Fortunately
QuicTransportServerSessionTest does not need a QuicCryptoServerStream, only a
QuicCryptoServerStreamBase: it calls OnSuccessfulVersionNegotiation() which is a
QuicCryptoStream method, and passes it to  HandshakeWithFakeClient() which takes
a QuicCryptoServerStreamBase*.
PiperOrigin-RevId: 291203032
Change-Id: I7b3ec41c64eeb46074ee6aa98bff7bd132a20daa