)]}'
{
  "commit": "202240c353a6852fb47fb717b00c62373cab52b6",
  "tree": "ae33cb8902430dbd78559f98dfb1b156f958019a",
  "parents": [
    "149b7e62d395d82ef53c948262cf0ab3e84b4236"
  ],
  "author": {
    "name": "awillia",
    "email": "awillia@google.com",
    "time": "Mon Jul 08 09:47:00 2024 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Mon Jul 08 09:48:07 2024 -0700"
  },
  "message": "Improve QuicConnectionTest test times\n\nCertain QuicConnectionTest tests result in warnings like the following:\n\n```\nGMOCK WARNING:\n../../net/third_party/quiche/src/quiche/quic/core/quic_connection_test.cc:2609: Actions ran out in EXPECT_CALL(*send_algorithm_, OnPacketSent(_, _, _, _, _))...\nCalled 2 times, but only 1 WillOnce() is specified - returning directly.\nStack trace:\n...\n```\n\nStack trace symbolization takes a long time in Chromium unit tests (see https://crbug.com/340987671), so avoiding these warnings reduces the test execution times from seconds to a few milliseconds. IIUC the changes in this CL don\u0027t affect the test behavior and just suppress the warnings.\n\nAffected tests with test execution times from my gLinux cloudtop:\n\n - NoNonProbingFrameOnAlternativePath (41385 ms)\n - ReceivePathProbingFromNewPeerAddressAtServer (9948 ms)\n - ClientResponseToPathChallengeOnAlternativeSocket (2266 ms)\n - DuplicateAckCausesLostPackets (1991 ms)\n - PathValidationOnNewSocketSuccess (2241 ms)\n - PathValidationReceivesStatelessReset (2289 ms)\n - SendPathChallengeUsingBlockedNewSocket (2215 ms)\n - PathChallengeBeforePeerIpAddressChangeAtServer (2284 ms)\n - DetectSimutanuousServerAndClientAddressChangeWithProbe (2358 ms)\n\nAll the tests above are parameterized with similar test execution times for the following variants:\n - RFCv2_defer\n - RFCv2_immediate\n - RFCv1_defer\n - RFCv1_immediate\n - draft29_defer\n - draft29_immediate\n\nThe DuplicateAckCausesLostPackets test was also slow for the Q046_defer variant.\n\nPiperOrigin-RevId: 650281559\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "decb72d1b8f647c3ab972b3a7851dffb9dee8ce0",
      "old_mode": 33188,
      "old_path": "quiche/quic/core/quic_connection_test.cc",
      "new_id": "28bb07cdb4055955c3e47e496616022da29fb57a",
      "new_mode": 33188,
      "new_path": "quiche/quic/core/quic_connection_test.cc"
    }
  ]
}