)]}'
{
  "commit": "1c41a1dd37684890d0070642f55ce88d9b19ba32",
  "tree": "9b192f53a8c1a40bd6d416aaa5fb1fc9984e2334",
  "parents": [
    "b2b26157b6c22b7bb8e7b7e0039033ccaa5e6d8b"
  ],
  "author": {
    "name": "dschinazi",
    "email": "dschinazi@google.com",
    "time": "Wed Jul 01 10:49:08 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Jul 01 10:49:57 2020 -0700"
  },
  "message": "Fix memory safety issues in e2e test\n\nThis test contained multiple memory safety issues that would trigger if something failed. For example, if the handshake fails, there might not be a server connection and session created, and our code would previously use uninitialized memory as its session. Similarly, we would dereference header values even if we failed to find the right header, leading to use of uninitialized memory.\n\nTo fix these issues, this CL refactors some code to convenience methods that perform proper checks, and make sure the test is marked as failed if any of the convenience methods return early due to a missing object.\n\nNote that we need to pause the server thread in order to safely access server variables, and we need to then resume the server thread even if there were failures, therefore tests cannot use ASSERTs when the server thread is paused.\n\ngf-relnote: n/a, test-only change\nPiperOrigin-RevId: 319255234\nChange-Id: Ic1281bb2dd1217e1303fca1f20cb4275a343cc1c\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f333264ad3c80e77d40620ac03f7c21c41ea6261",
      "old_mode": 33188,
      "old_path": "quic/core/http/end_to_end_test.cc",
      "new_id": "02e1c66c05288b0aeab7c98100ddec8edfcfc909",
      "new_mode": 33188,
      "new_path": "quic/core/http/end_to_end_test.cc"
    }
  ]
}